On Wed, 15 Nov 2023 12:35:50 GMT, Kevin Rushforth wrote:
>> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match
>> JDK 22.
>>
>> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
>
> Kevin Rushforth has updated the pull request with a new target base
On Wed, 15 Nov 2023 19:47:28 GMT, Marius Hanl wrote:
>> this might be problematic, as it uses undocumented aspect of
>> Text/Flow.caretShape(). the current implementation returns either a single
>> line, or two lines (moveto,lineto,moveto,lineto) in the case of split/dual
>> caret. But this
> The change listener on caretPositionProperty() was not getting invoked on
> replacing the content with same text as there was no change in caret
> position. Since the textProperty invalidation sets the forward bias to true
> by default, incorrect caret position was calculated when the same te
Alright, I will see what I can do. I was not able to reproduce it every
time, so I hope it doesn't get too tricky.
On 11/16/2023 12:20 AM, Andy Goryachev wrote:
Dear Christopher:
You application does look nice!
Please understand that without an SCCE, it would be nearly impossible
for us to
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Thu, 16 Nov 2023 00:20:16 GMT, Andy Goryachev wrote:
> Do you think some other layouts should be added to the keyboard test?
> (Suggestion: Arabic, Hebrew, Japanese, French, Russian)
>
> Another suggestion: maybe add the instructions to the KeyboardTest window?
Those both sound like good su
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Thu, 16 Nov 2023 00:10:24 GMT, Martin Fox wrote:
> as long as the test and your selected keyboard match.
ah! my fault, did not read the javadoc. let me try again.
-
PR Comment: https://git.openjdk.org/jfx/pull/1209#issuecomment-1813501958
On Wed, 15 Nov 2023 23:08:44 GMT, Andy Goryachev wrote:
> 1. Using French keyboard on mac (and windows), Ctrl-- is expected to produce
> the key code RIGHT_PARENTHESIS, correct?
Yes, that key turns into right parenthesis with a French layout.
> 2. Using KeyboardTest, I am getting:
You should
Dear colleagues:
I wanted to share some of the feedback we received which might be relevant to
the input map / behavior discussion (and sorry for not sending it earlier).
Email addresses in DM are redacted (though some of the responses might be from
this mailing list anyway).
Robert REDACTE
Dear Christopher:
You application does look nice!
Please understand that without an SCCE, it would be nearly impossible for us to
do anything. I can help in creating a bug, but a minimal reproducible example
is absolute must.
-andy
From: openjfx-dev on behalf of Christopher
Schnick
Date:
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
In the spirit of the season, here is my wish list (in no particular order):
- bundling javafx with jdk by default
- playback/display of all the modern A/V/I formats (webp, heic, svg, ...)
- application framework: settings, ui preferences, actions, programmatic css,
platform api
- cross-platform j
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Adding accessibilityMinValue and accessibility
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought i
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought i
I agree with Wayland. It is inevitable, and I want JavaFX to perform well
on Linux.
On Wed, Nov 15, 2023 at 2:16 PM Thiago Milczarek Sayão <
thiago.sa...@gmail.com> wrote:
> Hi,
>
> I would choose:
>
> - Wayland
> - Vulkan rendering
> - Copyable labels
> - A pay raise for Kevin :)
>
>
>
>
>
>
>
>
- more reviewers to tackle the perpetual review bottleneck
On Wed, 15 Nov 2023 19:50:34 GMT, Kevin Rushforth wrote:
> Clean backport of compiler update to jfx21u
This pull request has now been integrated.
Changeset: f78ee4e7
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx21u/commit/f78ee4e798c4202f59e656b370bd343e0b3df486
Stats:
Clean backport of compiler update to jfx21u
-
Commit messages:
- Backport 2d4b494ea9cee1acd0407b9de61f0af9163f5d62
Changes: https://git.openjdk.org/jfx21u/pull/29/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=29&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8319
On Wed, 15 Nov 2023 14:07:36 GMT, Kevin Rushforth wrote:
> Clean backport of critical macOS 14 fix to 21u.
This pull request has now been integrated.
Changeset: 4953439f
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx21u/commit/4953439fab81fc1808ad071fb1665103929f2fe1
Stats:
On Wed, 15 Nov 2023 19:02:09 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
>> line 248:
>>
>>> 246: textNode.caretShapeProperty().addListener(observable -> {
>>> 247:
>>> caretPath.getElements().setAll(textN
On Tue, 14 Nov 2023 20:52:55 GMT, Kevin Rushforth wrote:
> Clean backport of compiler update to jfx21u
This pull request has now been integrated.
Changeset: 5a1a12a9
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx21u/commit/5a1a12a91618a2198b31afbdcb4cda2d7967
Stats:
My bigger question is asking what you lose by having AWT in JavaFX. Is
there something fundamentally problematic about it that its removal would
solve/alleviate a problem?
Whereas on the other hand, AWT has some very useful libraries that are in
use by nearly all Java GUI frameworks. For example,
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
On Tue, 31 Oct 2023 19:20:48 GMT, brunesto wrote:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
This pull request has now been integrated.
Changeset: 59c86bbe
Author:brunesto
Committer: Andy Goryachev
URL:
https://git.openjdk.org/jfx/commit/59c86b
On Wed, 15 Nov 2023 18:20:14 GMT, Marius Hanl wrote:
>> The change listener on caretPositionProperty() was not getting invoked on
>> replacing the content with same text as there was no change in caret
>> position. Since the textProperty invalidation sets the forward bias to true
>> by default
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
import
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.ope
On Wed, 15 Nov 2023 18:58:02 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> import
perfection achieved :-)
--
On Wed, 15 Nov 2023 18:52:17 GMT, brunesto wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java
>> line 32:
>>
>>> 30: import java.time.LocalDate;
>>> 31: import java.time.DateTimeException;
>>> 32: import java.time.format.DateTimeParseException;
>>
>> is this i
On Wed, 15 Nov 2023 18:52:17 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> DatePicker on focus lost catches all except
On Wed, 15 Nov 2023 18:51:28 GMT, Andy Goryachev wrote:
>> brunesto has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> DatePicker on focus lost catches all exceptions around commit
>
> modules/javafx.controls/src/main/java/javafx/scene/cont
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
DatePicker on focus lost catches all exceptions around commit
-
Changes:
- all: https://git.o
On Wed, 15 Nov 2023 18:15:51 GMT, Marius Hanl wrote:
> I just wonder if we want to catch `Exception` here as well, as it was done in
> the old code.
> The contract then would be: If a converter throws any exception, we cancel
> the edit.
There might be some discussion on that, but yes, I'd rat
On Wed, 15 Nov 2023 18:10:28 GMT, Marius Hanl wrote:
>> brunesto has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> inlined
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/DatePickerTest.java
> line 765:
>
>> 763:
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
minor
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.open
On Wed, 2023-11-15 at 15:37 -0300, Thiago Milczarek Sayão wrote:
> - Vulkan rendering
Seconded!
> - A pay raise for Kevin :)
Seconded!
--
Mark Raynsford | https://www.io7m.com
+1 for pay raise for Kevin
:-)
-andy
From: openjfx-dev on behalf of Thiago Milczarek
Sayão
Date: Wednesday, November 15, 2023 at 10:38
To: Dirk Lemmermann
Cc: openjfx-dev
Subject: Re: My JavaFX Christmas Wishlist
Hi,
I would choose:
- Wayland
- Vulkan rendering
- Copyable labels
- A pay
Hi,
I would choose:
- Wayland
- Vulkan rendering
- Copyable labels
- A pay raise for Kevin :)
Em qua., 15 de nov. de 2023 07:25, Dirk Lemmermann
escreveu:
> Hi guys,
>
> I already mentioned this at the JavaFX BOF at DEVOXX and also posted this
> on Twitter but wanna make sure it gets th
On Tue, 14 Nov 2023 10:24:20 GMT, Karthik P K wrote:
> The change listener on caretPositionProperty() was not getting invoked on
> replacing the content with same text as there was no change in caret
> position. Since the textProperty invalidation sets the forward bias to true
> by default, in
On Wed, 15 Nov 2023 09:37:23 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> inlined
Looks good to me, just some minor
On Wed, 15 Nov 2023 00:54:26 GMT, Martin Fox wrote:
>> @beldenfox thank you. I still not entirely sure what issue is being tested
>> and how to fix it, between this PR and JBS.
>> For example, when I run the application listed in JBS description with your
>> fix, I get one "HI" - is it expecte
On Wed, 15 Nov 2023 00:54:26 GMT, Martin Fox wrote:
> What keyboard layout do you normally use on Windows?
US layout on both, at least when the events were captured in the previous
comment.
-
PR Comment: https://git.openjdk.org/jfx/pull/1209#issuecomment-1812868772
On Wed, 15 Nov 2023 09:37:23 GMT, brunesto wrote:
>> The fix prevents the DatePicker from losing focus if the date is not
>> parsable.
>
> brunesto has updated the pull request incrementally with one additional
> commit since the last revision:
>
> inlined
Looks good, thank you for making t
3D: unfortunately that is completely out of my comfort zone … for this feature
request I am merely the messenger.
AWT: I was thinking that this is mostly a refactoring and probably code
duplication?
Dirk
> Am 15.11.2023 um 14:28 schrieb Nir Lisker :
>
>> 3D line and point primitives
>
> I fil
Clean backport of critical macOS 14 fix to 21u.
-
Commit messages:
- Backport 986ec4f9b632f950111015be9445d0bae73042eb
Changes: https://git.openjdk.org/jfx21u/pull/28/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=28&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
>
> 3D line and point primitives
>
I filed https://bugs.openjdk.org/browse/JDK-8316398 for this already. As
noted, it requires a somewhat complex computation for intersections and
possibly for contains. If you would like to write these Mesh classes, like
the current TriangleMesh, I can write the r
On Thu, 9 Nov 2023 02:45:34 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DPhongMaterial.cc line 39:
>
>> 37:
On Mon, 13 Nov 2023 01:23:13 GMT, Michael Strauß wrote:
>> About 2, I tried that initially and got into problems iterating over the
>> enum in `D3DMeshView.cc` line 293. How would you perform the iteration?
>
> You're right, there's no implicit conversion from scoped enums to integers.
> While
On Thu, 2 Nov 2023 19:49:52 GMT, Thiago Milczarek Sayao
wrote:
> Observed that the window manager takes care of showing and hiding children
> because we set `gtk_window_set_transient_for`.
>
> Works since Ubuntu 16.04.
>
> This PR removes the code to show or hide children because it "duplicat
On Fri, 10 Nov 2023 15:24:13 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/paint/TextureData.java
>> line 12:
>>
>>> 10: */
>>> 11: // Here we can support mipmaps, wrapping modes (which exists internally
>>> and can be pulled out), addressing modes etc.
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A foll
> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match
> JDK 22.
>
> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains two com
On Mon, 13 Nov 2023 18:47:14 GMT, Kevin Rushforth wrote:
> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from
> 17.5.0) to match JDK 22.
>
> I've run headless and headful tests.
This pull request has now been integrated.
Changeset: 2d4b494e
Author:Kevin Rushforth
On Wed, 8 Nov 2023 15:04:44 GMT, Kevin Rushforth wrote:
> Fix [JDK-8319669](https://bugs.openjdk.org/browse/JDK-8319669) as follows:
>
> 1. Override the `NSApplicationDelegate` method
> `applicationSupportsSecureRestorableState` in `GlassApplication` and return
> `YES`. This silences the warni
On Wed, 2023-11-15 at 09:47 +0100, Dirk Lemmermann wrote:
>
> All I want for Christmas is … / what I think is needed for JavaFX
> going forward ...
Is it sad that all I really want for Christmas is to be able to specify
that text under a certain size threshold shouldn't be antialiased? My
JavaFX
On Thu, 2 Nov 2023 19:49:52 GMT, Thiago Milczarek Sayao
wrote:
> Observed that the window manager takes care of showing and hiding children
> because we set `gtk_window_set_transient_for`.
>
> Works since Ubuntu 16.04.
>
> This PR removes the code to show or hide children because it "duplicat
On Tue, 14 Nov 2023 21:31:59 GMT, Andy Goryachev wrote:
>> brunesto has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java
> line 151:
>
>> 149: focu
> The fix prevents the DatePicker from losing focus if the date is not parsable.
brunesto has updated the pull request incrementally with one additional commit
since the last revision:
inlined
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1274/files
- new: https://git.op
Hi guys,
I already mentioned this at the JavaFX BOF at DEVOXX and also posted this on
Twitter but wanna make sure it gets the visibility it deserves:
All I want for Christmas is … / what I think is needed for JavaFX going forward
...
- removal of AWT
- a tray API (tray icon)
61 matches
Mail list logo