Re: RFR: 8301302: Platform preferences API [v26]

2023-11-17 Thread Michael Strauß
On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance

Re: RFR: 8301302: Platform preferences API [v23]

2023-11-17 Thread Michael Strauß
On Fri, 17 Nov 2023 19:03:16 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename Appearance to ColorScheme > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line

Re: RFR: 8301302: Platform preferences API [v26]

2023-11-17 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally

Re: RFR: 8301302: Platform preferences API [v23]

2023-11-17 Thread Michael Strauß
On Fri, 17 Nov 2023 19:43:58 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename Appearance to ColorScheme > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line

Re: RFR: 8301302: Platform preferences API [v25]

2023-11-17 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally

javafx.base and java.desktop

2023-11-17 Thread Nir Lisker
Hi, A previous discussion mentioned the removal of AWT dependencies. One of the points that Kevin brought up was Refactor Java Beans implementation in javafx.base such that java.desktop > is optional John and I looked at this some time ago when we discussed the usage of the javafx base module

Re: RFR: 8301302: Platform preferences API [v23]

2023-11-17 Thread Michael Strauß
On Fri, 17 Nov 2023 19:20:32 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename Appearance to ColorScheme > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line

Re: [External] : Re: ImageView.fitWidth()/.fitHeight()/.preserveRatio() styling

2023-11-17 Thread Andy Goryachev
Created https://bugs.openjdk.org/browse/JDK-8320359 -andy From: Dirk Lemmermann Date: Friday, November 17, 2023 at 14:48 To: Andy Goryachev Cc: openjfx-dev Subject: [External] : Re: ImageView.fitWidth()/.fitHeight()/.preserveRatio() styling I guess the use-case is the same as for any node

Re: ImageView.fitWidth()/.fitHeight()/.preserveRatio() styling

2023-11-17 Thread Dirk Lemmermann
I guess the use-case is the same as for any node property. I want to be able to specify it via CSS instead of code. I could easily implement this for ImageView but I am not familiar with the OpenJFX dev process (e.g. which tests are required), so it would take me a long time to do. Pretty sure

Re: RFR: 8301302: Platform preferences API [v24]

2023-11-17 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally

Re: RFR: 8318387: Update GStreamer to 1.22.6

2023-11-17 Thread Kevin Rushforth
On Fri, 17 Nov 2023 21:27:04 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. > - Tested on all platforms with all supported media streams. > - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older > GLib versions on Linux following

RFR: 8318387: Update GStreamer to 1.22.6

2023-11-17 Thread Alexander Matveev
- GStreamer updated to 1.22.6 and GLib updated to 2.78.1. - Tested on all platforms with all supported media streams. - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older GLib versions on Linux following APIs were changed from new to old one (restored GStreamer 1.20.1

Re: Behavior Proposal v2

2023-11-17 Thread Andy Goryachev
Thank you, John, for a productive discussion! I am very happy to see that we both gained a better understanding of the problems we are trying to solve. For me, some of the insights came to light after our conversation. To complement John’s list: - in cases where the behavior part is

Re: RFR: 8301302: Platform preferences API [v5]

2023-11-17 Thread Kevin Rushforth
On Wed, 6 Sep 2023 18:02:31 GMT, Kevin Rushforth wrote: >> +1 >> >> we could put the doc (in markdown format) in the doc-files/platform >> directory (or create any other subdirectory, see JDK-8309749) > > I think Michael meant that the javadoc-generated API docs in this file need > to be kept

Re: RFR: 8301302: Platform preferences API [v23]

2023-11-17 Thread Kevin Rushforth
On Fri, 10 Nov 2023 21:23:54 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance

RFR: 8089373: Translation from character to key code is not sufficient

2023-11-17 Thread Martin Fox
On Windows a common shortcut like Ctrl+'+' could only be invoked from the main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not have enough context to know whether it should return a result from the main keyboard or the keypad. This PR alters getKeyCodeForChar to pass in

RE: My JavaFX Christmas Wishlist

2023-11-17 Thread Jan Tosovsky
On 2023-11-15, Dirk Lemmermann wrote: > > All I want for Christmas is … / what I think is needed for JavaFX > going forward ... I wish JavaFX better MARKETING. If I sometimes encounter articles comparing various frameworks for building desktop apps, JavaFX is never listed. I was sad about

Re: CFV: New OpenJFX Committer: Martin Fox

2023-11-17 Thread José Pereda
Vote: Yes Jose On Fri, Nov 17, 2023 at 3:34 PM John Hendrikx wrote: > Vote: YES > > --John > > On 16/11/2023 16:54, Kevin Rushforth wrote: > > I hereby nominate Martin Fox [1] to OpenJFX Committer. > > > > Martin is an OpenJFX community member, who has contributed 12 commits > > [2] to

Re: CFV: New OpenJFX Committer: Florian Kirmaier

2023-11-17 Thread José Pereda
Vote: Yes Jose On Fri, Nov 17, 2023 at 3:34 PM John Hendrikx wrote: > Vote: YES > > --John > > On 16/11/2023 16:38, Kevin Rushforth wrote: > > I hereby nominate Florian Kirmaier [1] to OpenJFX Committer. > > > > Florian is an OpenJFX community member, who has contributed 24 commits > > [2] to

Re: CFV: New OpenJFX Committer: Florian Kirmaier

2023-11-17 Thread John Hendrikx
Vote: YES --John On 16/11/2023 16:38, Kevin Rushforth wrote: I hereby nominate Florian Kirmaier [1] to OpenJFX Committer. Florian is an OpenJFX community member, who has contributed 24 commits [2] to OpenJFX. Votes are due by November 30, 2023 at 16:00 UTC. Only current OpenJFX Committers

Re: CFV: New OpenJFX Committer: Martin Fox

2023-11-17 Thread John Hendrikx
Vote: YES --John On 16/11/2023 16:54, Kevin Rushforth wrote: I hereby nominate Martin Fox [1] to OpenJFX Committer. Martin is an OpenJFX community member, who has contributed 12 commits [2] to OpenJFX. Votes are due by November 30, 2023 at 16:00 UTC. Only current OpenJFX Committers [3]

Behavior Proposal v2

2023-11-17 Thread John Hendrikx
I'm working on a new version of the behavior proposal after some fruitful discussions here on this list, and a meeting with Andy. In this meeting a few problems I was unable to address came to light, and which I've now addressed in this post: 1) TextAreaBehavior is relying heavily on

Re: Public Behavior API proposal

2023-11-17 Thread John Hendrikx
On 13/11/2023 07:14, Michael Strauß wrote: Hi John, I think this is an excellent summary of all the discussions so far, and the best proposal I've seen for a comprehensive control architecture capable of addressing many shortcomings of the existing controls. Here are some thoughts: 1.

Re: Public Behavior API proposal

2023-11-17 Thread John Hendrikx
Hi Andy, I don't think these really qualify as a good enough reason to expose an InputMap API by themselves. The first comment sounds like an X/Y problem, where the user wants to achieve X (remove unwanted behavior) and thinks Y (exposing InputMap) is the solution -- certainly that is