Looing for feedback: Behavior API Proposal V2

2023-11-24 Thread John Hendrikx
Hi List, I've written down a new Behavior API proposal which has some interesting changes to even better separate behavior from skins. Skins currently already determine much of the behavior by only installing specific event handlers, or only calling behaviors in specific instances (they effe

Re: RFR: 8301302: Platform preferences API [v30]

2023-11-24 Thread Michael Strauß
On Fri, 24 Nov 2023 21:57:04 GMT, John Hendrikx wrote: >> I don't understand. This is an overridden method, do you propose to >> introduce another `private static final` method, and >> `getPlatformKeyMappings` then calls out to this other method? > > I meant that it is a constant, which I think

Re: RFR: 8301302: Platform preferences API [v32]

2023-11-24 Thread John Hendrikx
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v30]

2023-11-24 Thread John Hendrikx
On Fri, 24 Nov 2023 18:07:01 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line >> 793: >> >>> 791: * Returns a mapping of platform-specific keys to the types of >>> their values. >>> 792: * Polymorphic types are supported by sp

Re: RFR: 8301302: Platform preferences API [v32]

2023-11-24 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: RFR: 8301302: Platform preferences API [v30]

2023-11-24 Thread Michael Strauß
On Fri, 24 Nov 2023 11:41:30 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> flip S and T > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line > 770: > >> 768: >>

Re: RFR: 8301302: Platform preferences API [v31]

2023-11-24 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: [External] : Re: Prioritized event handlers

2023-11-24 Thread Martin Fox
While digging around in the bug database I ran across a bug that was already filed on this issue. I don’t recall it being mentioned during this discussion, my apologies if it was and I just forgot. https://bugs.openjdk.org/browse/JDK-8231245 Controls' behavior must not depend on sequence of hand

Re: RFR: 8313648: JavaFX application continues to show a black screen after graphic card driver crash

2023-11-24 Thread mintykat
On Sat, 5 Aug 2023 12:28:16 GMT, Thorsten Fischer wrote: > Hi, > > I did open the bug report. Some notes to this PR: > > My colleagues and I are able to reproduce this bug regularly, even though it > takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows > up. We are curre

Re: RFR: 8301302: Platform preferences API [v30]

2023-11-24 Thread John Hendrikx
On Fri, 24 Nov 2023 05:36:07 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.