Re: RFR: 8321573: Enhance documentation for Platform.Preferences.accentColor

2023-12-08 Thread Nir Lisker
On Sat, 9 Dec 2023 07:07:27 GMT, Michael Strauß wrote: > This PR enhances the documentation of `Platform.Preferences.accentColor`: > > >/** > - * The accent color. > + * The accent color, which is usually a vivid color that contrasts with > the foreground > + * and background colors.

RFR: 8321573: Enhance documentation for Platform.Preferences.accentColor

2023-12-08 Thread Michael Strauß
This PR enhances the documentation of `Platform.Preferences.accentColor`: /** - * The accent color. + * The accent color, which is usually a vivid color that contrasts with the foreground + * and background colors. It can be used to highlight the active or important part of a + * con

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Joeri Sykora
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version updat

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Kevin Rushforth
On Fri, 8 Dec 2023 14:47:04 GMT, Johan Vos wrote: > We typically do a full build, with SDK's and JMOD's and Javadoc etc, on the > supported platforms. Given the large amount of platform-specific code in our > gradle files, this is something that needs to be tested on different > platforms. Ye

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Johan Vos
On Fri, 8 Dec 2023 14:37:31 GMT, Nir Lisker wrote: > I just ran a build with this setup. The build succeeded (I didn't build > Webkit). Is there anything else to test? We typically do a full build, with SDK's and JMOD's and Javadoc etc, on the supported platforms. Given the large amount of pla

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Nir Lisker
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version updat

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Kevin Rushforth
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version updat

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Kevin Rushforth
On Fri, 8 Dec 2023 13:13:31 GMT, Kevin Rushforth wrote: >> Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. >> We need to update Gradle to 8.5 in order to update the boot JDK. >> There are not API level changes in Gradle that we need to work on, hence the >> change is only Gradle version

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Kevin Rushforth
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version updat

Re: [External] : Re: Reflective discovery of styleable properties

2023-12-08 Thread Nir Lisker
It certainly can't all be generated, but what I said is that a lot of it can, like the class entries which include the class specifier and table. These are the majority of the document. The amount of work will depend on how far we will take the annotation or reflection route. Some of the suggestio