Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-11 Thread Ambarish Rapte
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one addition

Re: RFR: 8321626: [testbug] Mark DualWindowTest and ContextMenuNPETest unstable on Linux

2023-12-11 Thread Karthik P K
On Mon, 11 Dec 2023 13:10:55 GMT, Kevin Rushforth wrote: > Until JDK-8321624 and JDK-8321625 are fixed, mark the following two tests as > unstable on Linux, meaning they will not be run as part of our nightly > headful test runs. > > DualWindowTest - [JDK-8321624](https://bugs.openjdk.org/brow

Integrated: 8321434: Update Gradle to 8.5

2023-12-11 Thread Ambarish Rapte
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version updat

Re: Converting a Color object to its string representation

2023-12-11 Thread Scott Palmer
I agree. I was going to write pretty much this exact email, but you beat me to it. I was implementing some user-configurable colour customizations in an application and needed to do it with style sheets, along with something that reads colours along the lines of what the new platform preferences

Integrated: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Jose Pereda
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote: > This PR prevents changes in direction when dragging a tab header over a > TabPane control, if delta value is zero, which can happen with slow drag > events, in order to prevent starting and stopping too frequently the > animation of the ta

RE: Converting a Color object to its string representation

2023-12-11 Thread Eran Leshem
Thank you for your responses. Given that the framework requires colors in string format in its style APIs, I think it should provide some way to convert colors to strings as expected by these APIs. Otherwise, clients are forced to implement this bridging logic on their own, due to a framework g

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Kevin Rushforth
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote: > This PR prevents changes in direction when dragging a tab header over a > TabPane control, if delta value is zero, which can happen with slow drag > events, in order to prevent starting and stopping too frequently the > animation of the ta

Possible to deploy patched openjfx locally?

2023-12-11 Thread Mark Raynsford
Hello! I'm attempting to experiment with some patches to OpenJFX locally. Is there a straightforward way to publish the resulting jar files to my local ~/.m2 repository? There appears to be a `MAVEN_PUBLISH` property, but this just results in: $ sh gradlew -PMAVEN_PUBLISH=true sdk ... * What we

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Kevin Rushforth
On Mon, 11 Dec 2023 19:04:49 GMT, Jose Pereda wrote: >> it is sort of equivalent in this case... >> I think this code is correct. > > It is the same as using `dragDelta != 0`, since `dragDelta = 0` implies > `dragDirection = 0`. > > The if-else expression doesn't provide a value for the case `d

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Michael Strauß
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote: > This PR prevents changes in direction when dragging a tab header over a > TabPane control, if delta value is zero, which can happen with slow drag > events, in order to prevent starting and stopping too frequently the > animation of the ta

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Jose Pereda
On Mon, 11 Dec 2023 19:01:19 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java >> line 2162: >> >>> 2160: } >>> 2161: // Stop dropHeaderAnim if direction of drag is changed >>> 2162: if (dragDirection != 0 && p

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Andy Goryachev
On Mon, 11 Dec 2023 18:51:09 GMT, Kevin Rushforth wrote: >> This PR prevents changes in direction when dragging a tab header over a >> TabPane control, if delta value is zero, which can happen with slow drag >> events, in order to prevent starting and stopping too frequently the >> animation o

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Andy Goryachev
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote: > This PR prevents changes in direction when dragging a tab header over a > TabPane control, if delta value is zero, which can happen with slow drag > events, in order to prevent starting and stopping too frequently the > animation of the ta

Integrated: 8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64

2023-12-11 Thread Kevin Rushforth
On Mon, 11 Dec 2023 13:13:04 GMT, Kevin Rushforth wrote: > Until [JDK-8318985](https://bugs.openjdk.org/browse/JDK-8318985) is fixed, we > will skip the 4 failing 3D light tests on Mac / aarch64 if the macOS version > is 14, meaning they will not be run as part of our nightly headful test runs

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Kevin Rushforth
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote: > This PR prevents changes in direction when dragging a tab header over a > TabPane control, if delta value is zero, which can happen with slow drag > events, in order to prevent starting and stopping too frequently the > animation of the ta

RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Jose Pereda
This PR prevents changes in direction when dragging a tab header over a TabPane control, if delta value is zero, which can happen with slow drag events, in order to prevent starting and stopping too frequently the animation of the target tab header in opposite directions. - Commit

Integrated: 8321573: Improve Platform.Preferences documentation

2023-12-11 Thread Michael Strauß
On Sat, 9 Dec 2023 07:07:27 GMT, Michael Strauß wrote: > This PR enhances the documentation of `Platform.Preferences.accentColor`: > > >/** > - * The accent color. > + * The accent color, which can be used to highlight the active or > important part of a > + * control and make it sta

Re: RFR: 8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64

2023-12-11 Thread Kevin Rushforth
On Mon, 11 Dec 2023 15:39:03 GMT, Andy Goryachev wrote: >> Until [JDK-8318985](https://bugs.openjdk.org/browse/JDK-8318985) is fixed, >> we will skip the 4 failing 3D light tests on Mac / aarch64 if the macOS >> version is 14, meaning they will not be run as part of our nightly headful >> test

Re: RFR: 8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64

2023-12-11 Thread Andy Goryachev
On Mon, 11 Dec 2023 13:13:04 GMT, Kevin Rushforth wrote: > Until [JDK-8318985](https://bugs.openjdk.org/browse/JDK-8318985) is fixed, we > will skip the 4 failing 3D light tests on Mac / aarch64 if the macOS version > is 14, meaning they will not be run as part of our nightly headful test runs

Re: RFR: 8321573: Improve Platform.Preferences documentation [v3]

2023-12-11 Thread Nir Lisker
On Sat, 9 Dec 2023 17:55:32 GMT, Michael Strauß wrote: >> This PR enhances the documentation of `Platform.Preferences.accentColor`: >> >> >>/** >> - * The accent color. >> + * The accent color, which can be used to highlight the active or >> important part of a >> + * control and mak

RFR: 8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64

2023-12-11 Thread Kevin Rushforth
Until [JDK-8318985](https://bugs.openjdk.org/browse/JDK-8318985) is fixed, we will skip the 4 failing 3D light tests on Mac / aarch64 if the macOS version is 14, meaning they will not be run as part of our nightly headful test runs or developer test build. - Commit messages: - 832

RFR: 8321626: [testbug] Mark DualWindowTest and ContextMenuNPETest unstable on Linux

2023-12-11 Thread Kevin Rushforth
Until JDK-8321624 and JDK-8321625 are fixed, mark the following two tests as unstable on Linux, meaning they will not be run as part of our nightly headful test runs. DualWindowTest - [JDK-8321624](https://bugs.openjdk.org/browse/JDK-8321624) ContextMenuNPETest - [JDK-8321625](https://bugs.openj

Re: RFR: 8321573: Improve Platform.Preferences documentation [v3]

2023-12-11 Thread Kevin Rushforth
On Sat, 9 Dec 2023 17:55:32 GMT, Michael Strauß wrote: >> This PR enhances the documentation of `Platform.Preferences.accentColor`: >> >> >>/** >> - * The accent color. >> + * The accent color, which can be used to highlight the active or >> important part of a >> + * control and mak