RE: Converting a Color object to its string representation

2023-12-12 Thread Eran Leshem
I can see two options: 1. Minimal, just in order to satisfy the style APIs need – supporting a single format. I would go with non-% rgba, since it covers all dimensions in the most straightforward way. 2. Complete – supporting all formats accepted by Color.web(), either via multipl

Integrated: 8321902: Robot-based Behavior tests must be under test.robot hierarchy

2023-12-12 Thread Andy Goryachev
On Tue, 12 Dec 2023 17:16:44 GMT, Andy Goryachev wrote: > Robot system tests must be in test.robot.* package hierarchy because gradle. This pull request has now been integrated. Changeset: 8872f7af Author:Andy Goryachev URL: https://git.openjdk.org/jfx/commit/8872f7afab5eca725b29d9e

Re: RFR: 8321902: Robot-based Behavior tests must be under test.robot hierarchy

2023-12-12 Thread Kevin Rushforth
On Tue, 12 Dec 2023 17:16:44 GMT, Andy Goryachev wrote: > Robot system tests must be in test.robot.* package hierarchy because gradle. Looks good. I confirm that after this fix, the tests are only run when `USE_ROBOT` is `true` - Marked as reviewed by kcr (Lead). PR Review: https

Re: The crisp fonts saga

2023-12-12 Thread Philip Race
Usage of hinting in UIs is on the way out. macOS stopped applying hints ages ago. Apple also canned LCD text. High DPI displays are obsoleting the raison d'etre of both of these. A big problem with hinting is that it distorts both the size and the shape, so UIs do not scale evenly and animations

RFR: 8321902: Robot-based Behavior tests must be under test.robot hierarchy

2023-12-12 Thread Andy Goryachev
Robot system tests must be in test.robot.* package hierarchy because gradle. - Commit messages: - 8321902: Robot-based Behavior tests must be under test.robot hierarchy Changes: https://git.openjdk.org/jfx/pull/1306/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1306&range=

Re: The crisp fonts saga

2023-12-12 Thread Mark Raynsford
On Tue Dec 12 16:03:50 UTC 2023, Thiago Milczarek Sayão wrote: > Fonts started to look better on Ubuntu 23.04 > https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6190 > May be related to this change. Hello! To be clear: All the tests I performed were against the last "release" version of JavaFX

Withdrawn: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs

2023-12-12 Thread duke
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote: > This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they wer

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v8]

2023-12-12 Thread Andy Goryachev
> Modified the resize algorithm to work well with fractional scale, thanks for > deeper understanding of the problem thanks to @hjohn and @mstr2 . > > It is important to note that even though the constraints are given by the > user in unsnapped coordinates, they are converted to snapped values,

Re: The crisp fonts saga

2023-12-12 Thread Thiago Milczarek Sayão
The dates don't match since the change is from 4 months ago and 23.04 was released on April. So it was some other change. Em ter., 12 de dez. de 2023 13:03, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Fonts started to look better on Ubuntu 23.04 > > https://gitlab.gnome.org/GNOME

Re: Converting a Color object to its string representation

2023-12-12 Thread Andy Goryachev
I also think that the platform will benefit from adding this symmetrical API. It is less clear how that new API should deal with all the multiple variants of the web format (#rgb, #rrggbb, rgb, rgba, 0x*, ...). -andy From: openjfx-dev on behalf of Scott Palmer Date: Monday, December 11, 20

Re: The crisp fonts saga

2023-12-12 Thread Thiago Milczarek Sayão
Fonts started to look better on Ubuntu 23.04 https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6190 May be related to this change. Em ter., 12 de dez. de 2023 11:10, Mark Raynsford escreveu: > Hello! > > I've never been particularly satisfied with the font rendering in > JavaFX. In particula

Unable to select row in TableView depending on stage height

2023-12-12 Thread Kroiß , Florian
Hi everyone, there seems to be a bug where, depending on the current stage height, it is not possible to select a row in a TableView by clicking on it. There is an existing bug (https://bugs.openjdk.org/browse/JDK-8133697) which attributes this problem to maximizing the window, but I think it is

The crisp fonts saga

2023-12-12 Thread Mark Raynsford
Hello! I've never been particularly satisfied with the font rendering in JavaFX. In particular, on Linux, the text always appears very soft and blurry compared to non-JavaFX applications on the same system. Even applications that render antialiased text with Java2D seem to look better. I decided

Integrated: 8321626: [testbug] Mark DualWindowTest and ContextMenuNPETest unstable on Linux

2023-12-12 Thread Kevin Rushforth
On Mon, 11 Dec 2023 13:10:55 GMT, Kevin Rushforth wrote: > Until JDK-8321624 and JDK-8321625 are fixed, mark the following two tests as > unstable on Linux, meaning they will not be run as part of our nightly > headful test runs. > > DualWindowTest - [JDK-8321624](https://bugs.openjdk.org/brow

Re: RFR: 8321626: [testbug] Mark DualWindowTest and ContextMenuNPETest unstable on Linux

2023-12-12 Thread Ambarish Rapte
On Mon, 11 Dec 2023 13:10:55 GMT, Kevin Rushforth wrote: > Until JDK-8321624 and JDK-8321625 are fixed, mark the following two tests as > unstable on Linux, meaning they will not be run as part of our nightly > headful test runs. > > DualWindowTest - [JDK-8321624](https://bugs.openjdk.org/brow

Re: Possible to deploy patched openjfx locally?

2023-12-12 Thread Bruno Carle
Hi Mark, that worked for me recently: in build.gradle change line 546: defineProperty("MAVEN_PUBLISH", "true") and line 1730: (add brackets) artifact (project.tasks."modularPublicationJar$t.capital") { then sh ./gradlew publishToMavenLocal Regards Bruno On Mon, Dec 11, 2023 at 9:59 PM Mark Ra

Re: Possible to deploy patched openjfx locally?

2023-12-12 Thread Mark Raynsford
On Tue, 2023-12-12 at 11:29 +0100, John Hendrikx wrote: > Hi, > > Depending on what you want to do, if you're not using modules, you > can > just place a changed source file with your own sources (in their > original package) and it should override it. > Hehe, thanks! I had forgotten that that

RFR: 8320965: Scrolling on a touch enabled display fails on Wayland

2023-12-12 Thread Jose Pereda
This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and fixes the dragging issue on Wayland. - Commit mes

Re: Possible to deploy patched openjfx locally?

2023-12-12 Thread John Hendrikx
Hi, Depending on what you want to do, if you're not using modules, you can just place a changed source file with your own sources (in their original package) and it should override it. What also works (without modules) is to have a Maven module that has JFX as dependencies, and place changed