Re: RFR: 8089373: Translation from character to key code is not sufficient

2023-12-20 Thread Martin Fox
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote: > On Windows a common shortcut like Ctrl+'+' could only be invoked from the > main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not > have enough context to know whether it should return a result from the main > keyboard

RFR: 8322215: [win] OS events that close the stage can cause Glass to reference freed memory

2023-12-20 Thread Martin Fox
When a Stage is closed while processing an OS message the glass peer object is deleted immediately even if it's still executing member functions. As glass unwinds the stack and executes cleanup code it's referencing freed memory. There are cases where glass generates JavaFX events back-to-back.