Re: RFR: 8189282: JavaFX: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows [v6]

2024-01-09 Thread Ambarish Rapte
On Fri, 5 Jan 2024 01:22:59 GMT, Martin Fox wrote: >> When reporting input method candidate position the code in >> GlassViewEventHandler is not applying the platform scale factors. This is >> causing incorrect IM positions to be reported to glass on hi-dpi monitors. >> >> This PR a no-op on M

Withdrawn: 8311895: CSS Transitions

2024-01-09 Thread duke
On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; >

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v6]

2024-01-09 Thread Andy Goryachev
On Tue, 9 Jan 2024 13:19:53 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with two additiona

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v6]

2024-01-09 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with two additional commits since the last revision: - Cleanup test - Ad

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v6]

2024-01-09 Thread Johan Vos
On Tue, 9 Jan 2024 13:19:53 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with two additiona

Re: RFR: 8323209: Change JavaFX release version to 23

2024-01-09 Thread Johan Vos
On Mon, 8 Jan 2024 21:24:43 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 23. I will integrate this to master as > part of forking the jfx22 stabilization branch, which is scheduled for > Thursday, January 11, 2024 at 16:00 UTC. Marked as reviewed by jvos (Reviewer).