Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v2]

2024-01-13 Thread John Hendrikx
On Sun, 14 Jan 2024 04:20:56 GMT, Michael Strauß wrote: >> This is possible, although `List#get` would not perform too well when it is >> implemented for `FixedCapacitySet.OpenAddressed` as the array used as hash >> table in this class can have gaps (so we'd need to iterate to find the >>

Re: RFR: 8322215: [win] OS events that close the stage can cause Glass to reference freed memory

2024-01-13 Thread Michael Strauß
On Wed, 20 Dec 2023 17:31:57 GMT, Martin Fox wrote: > When a Stage is closed while processing an OS message the glass peer object > is deleted immediately even if it's still executing member functions. As > glass unwinds the stack and executes cleanup code it's referencing freed > memory. >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v2]

2024-01-13 Thread Michael Strauß
On Fri, 5 Jan 2024 01:32:04 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/css/SimpleSelector.java line 81: >> >>> 79: * @deprecated for future removal, use {@link >>> #getStyleClassNames()} instead >>> 80: */ >>> 81: public List getStyleClasses() { >>

Re: RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls [v2]

2024-01-13 Thread Sergey Bylokhov
On Thu, 11 Jan 2024 23:54:13 GMT, Kevin Rushforth wrote: >> As described in the JBS bug, there is a long-standing deadlock that happens >> on macOS between the AWT EDT and the JavaFX Application thread (which on >> macOS is the AppKit thread) when processing Input Method Events (IME) in a >>

Re: RFR: JDK-8323543: NPE when table items are set to null [v5]

2024-01-13 Thread Marius Hanl
On Thu, 11 Jan 2024 20:10:19 GMT, Andy Goryachev wrote: > I think the problem is that we are trying to address two issues in one PR - > the fix and migration to junit5. It might be better to go back one commit > (but keep the most recent changes on a separate branch), convert the fix to > use

Re: RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels

2024-01-13 Thread Johan Vos
On Fri, 12 Jan 2024 23:44:14 GMT, Andy Goryachev wrote: > 1. With variable height cells: if I click below the scrollbar thumb, followed > by a click above the thumb, I expect the view to go back to the same position > exactly, but it does not (see the screenshots). I think I've mentioned this