Re: RFR: JDK-8323543: NPE when table items are set to null [v6]

2024-01-14 Thread Carl Döbbelin
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables > items were null. Carl Döbbelin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v3]

2024-01-14 Thread John Hendrikx
On Sun, 14 Jan 2024 04:20:56 GMT, Michael Strauß wrote: >> This is possible, although `List#get` would not perform too well when it is >> implemented for `FixedCapacitySet.OpenAddressed` as the array used as hash >> table in this class can have gaps (so we'd need to iterate to find the >> inde

RFR: JDK-8323706 Move SimpleSelector and CompoundSelector to internal packages

2024-01-14 Thread John Hendrikx
Moves `SimpleSelector` and `CompoundSelector` to internal packages. This can be done with only a minor API break, as `SimpleSelector` and `CompoundSelector` were public before. However, these classes could not be constructed by 3rd parties. The only way to access them was by doing a cast (gen

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v3]

2024-01-14 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized and

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v2]

2024-01-14 Thread John Hendrikx
On Sun, 14 Jan 2024 04:58:35 GMT, John Hendrikx wrote: >> If this method is not used anywhere, why do we need to expose >> `getStyleClassNames()` as new API to replace this one? I'm a bit puzzled by >> that, especially since you're saying that the API shouldn't be used. Why >> create something