Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v4]

On Thu, 18 Jan 2024 07:49:26 GMT, Karthik P K wrote: > Noticed a problem - on Windows 11 and on macOS 14.2.1 hit into shows > different values for Text and TextFlow. > Fixed this issue. Please check. - PR Comment: https://git.openjdk.org/jfx/pull/1323#issuecomment-1914110425

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v6]

> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation > conditions were not considered, hence hit test values such as character index > and insertion index values were incorrect. > > Added checks for RTL orientation of nodes and fixed the issue in > `getHitInfo()` to

Integrated: 8324239: JFXPanelHiDPITest fails on Windows 11

On Mon, 22 Jan 2024 09:01:10 GMT, Prasanta Sadhukhan wrote: > Test fails with > > JFXPanelHiDPITest > testScale FAILED > java.lang.NullPointerException: Cannot invoke > "java.awt.image.BufferedImage.getWidth()" because "pixelsIm" is null > > because scenePeer is not yet created as the

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v3]

> Cherry-picked changes related to webkit-2.42.4.Verified build on all > platforms. Sanity testing looks fine. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: space corrections - Changes: - all:

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update tests - Changes: - all:

StubToolkit breaks test

I found an old disabled test that is testing PrismTextLayout for which I have a PR outstanding (https://github.com/openjdk/jfx/pull/1236). The test I think is useful, but is loading real fonts (Monaco and Tahoma).  Locally this works when I don't use the StubToolkit to run the test, and (I

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v5]

On Sun, 28 Jan 2024 23:29:49 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v5]

> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v8]

> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Add system test - Changes: - all: