RFR: 8324233: Update JPEG Image Decoding Software to 9f

2024-02-19 Thread Jayathirth D V
IJG has released latest version of libjpeg 9f and we need to update our version also match 9f changes. IJG reference : https://www.ijg.org/ With updated changes both headless and headful tests are green on all platforms. Also while updating to 9f noticed that many files don't have latest

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread Karthik P K
On Mon, 19 Feb 2024 14:32:36 GMT, John Hendrikx wrote: >Okay, so let me summarize (and let me know if that's correct) @hjohn you have summarised it correctly. I understood your concern and thanks for explaining your suggestion it in details. I will look into this approach and get back to you.

Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v3]

2024-02-19 Thread Anirvan Sarkar
On Sat, 17 Feb 2024 18:11:09 GMT, Michael Strauß wrote: >> Platform preferences detection doesn't pick up effective macOS system >> preferences if AWT owns the NSApplication and has set its NSAppearance to a >> fixed value. >> >> The workaround is to set the system property >>

Integrated: 8089373: Translation from character to key code is not sufficient

2024-02-19 Thread Martin Fox
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote: > On Windows a common shortcut like Ctrl+'+' could only be invoked from the > main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not > have enough context to know whether it should return a result from the main >

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread John Hendrikx
On Mon, 19 Feb 2024 13:45:00 GMT, Karthik P K wrote: > > @karthikpandelu You mentioned there is special casing going on when a > > `Text` is part of a `TextFlow`. What are those cases and where is this > > happening? How does it even know that a `Text` is involved and that it is > > part of a

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread Karthik P K
On Thu, 15 Feb 2024 10:36:51 GMT, Karthik P K wrote: >> I think we should simplify the `getHitInfo` method in the `TextLayout` >> interface. >> >> The code currently seems to be making distinctions where there are none. >> `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo`

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-19 Thread Karthik P K
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread John Hendrikx
On Thu, 15 Feb 2024 10:36:51 GMT, Karthik P K wrote: >> I think we should simplify the `getHitInfo` method in the `TextLayout` >> interface. >> >> The code currently seems to be making distinctions where there are none. >> `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo`

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2024-02-19 Thread Michael Strauß
On Fri, 9 Feb 2024 03:37:17 GMT, Martin Fox wrote: >> On Windows a common shortcut like Ctrl+'+' could only be invoked from the >> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not >> have enough context to know whether it should return a result from the main >>

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Jose Pereda
On Mon, 19 Feb 2024 00:35:48 GMT, Thiago Milczarek Sayao wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add compile-time checks to GdkSeat > > A shot in the dark since I don't own a touch enabled monitor: > >

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread Karthik P K
On Wed, 14 Feb 2024 04:39:04 GMT, John Hendrikx wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java > line 432: > >>

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread Karthik P K
On Wed, 14 Feb 2024 04:33:00 GMT, John Hendrikx wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java > line 424: > >>

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-19 Thread Karthik P K
On Wed, 14 Feb 2024 04:27:42 GMT, John Hendrikx wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java > line 213: > >>

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v12]

2024-02-19 Thread Karthik P K
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation > conditions were not considered, hence hit test values such as character index > and insertion index values were incorrect. > > Added checks for RTL orientation of nodes and fixed the issue in > `getHitInfo()` to

[jfx22u] Integrated: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-19 Thread Jose Pereda
On Sat, 17 Feb 2024 20:00:22 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [e2f42c5b](https://github.com/openjdk/jfx/commit/e2f42c5b71ef061c614540508fbac3fb610b1ae3) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The