Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-21 Thread Karthik P K
On Wed, 21 Feb 2024 18:59:02 GMT, John Hendrikx wrote: > I'm unclear on this part, do you mean it's possible that multiple `Text` > objects could be hit at the same time? There should only be one `TextRun` at > a certain x/y coordinate right? > Yes there will be one TextRun at a certain x/y

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]

2024-02-21 Thread Kevin Rushforth
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Integrated: 8322748: Caret blinking in JavaFX should only stop when caret moves

2024-02-21 Thread Andy Goryachev
On Wed, 14 Feb 2024 22:44:07 GMT, Andy Goryachev wrote: > Move caret animation handling due to keyboard input to the Skin, by > registering a listener on the caretPosition property. This will restart > animation only when the caret position changes instead of every key press. > > This also

Re: UI scaling issues when physical and logical screen resolutions differ on Linux

2024-02-21 Thread Martin Fox
Christopher, I’ve entered a bug to track this. See https://bugs.openjdk.org/browse/JDK-8326428 JavaFX added support for scaling-factor back in 2016 to address an issue with Ubuntu 16. Since then I suspect that setting has fallen into disuse. I know that it’s not set in Ubuntu/Kubuntu 22 but I

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-21 Thread Kevin Rushforth
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This

Re: Proposal: JavaFX Incubator Modules

2024-02-21 Thread Kevin Rushforth
These are all good points. 1. I agree. This seems like a good idea for all the reasons you mention. 2. I'll add the additional information. And I like your suggestion to require a JEP (*) to either drop or finalize an incubating feature. 3. Yes, I was deliberately vague on what constitutes a

Re: RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors [v5]

2024-02-21 Thread Kevin Rushforth
On Mon, 5 Feb 2024 16:46:40 GMT, Martin Fox wrote: >> Turning on warnings-as-errors for the macOS glass native code. Deprecated >> declarations are excluded and still appear as warnings. >> >> In the code that tries to locate the application's dock icon there were >> three instances where

Re: RFR: 8321603: Bump minimum JDK version for JavaFX to JDK 21

2024-02-21 Thread Kevin Rushforth
On Wed, 21 Feb 2024 17:52:33 GMT, Andy Goryachev wrote: > Are there any special steps needed to re-configure github actions? No. We already bumped the boot JDK used to build JavaFX to JDK 21 a couple months ago (in the JavaFX 22 release). > Are there any other dependencies? Not that I know

Re: RFR: 8321603: Bump minimum JDK version for JavaFX to JDK 21 [v2]

2024-02-21 Thread Phil Race
On Wed, 21 Feb 2024 18:39:16 GMT, Kevin Rushforth wrote: >> This PR bumps the minimum version of the JDK needed to run JavaFX to **JDK >> 21**. >> >> In order for JavaFX to be able to use newer JDK features, such as code >> snippets (in API docs), record patterns, pattern matching for switch

Re: RFR: 8321603: Bump minimum JDK version for JavaFX to JDK 21 [v2]

2024-02-21 Thread Johan Vos
On Wed, 21 Feb 2024 18:39:16 GMT, Kevin Rushforth wrote: >> This PR bumps the minimum version of the JDK needed to run JavaFX to **JDK >> 21**. >> >> In order for JavaFX to be able to use newer JDK features, such as code >> snippets (in API docs), record patterns, pattern matching for switch

Re: Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-21 Thread Johan Vos
Hi Kevin, all, I agree with this proposal and with the rationale behind it. It provides a solid foundation for future consistent decisions as well. - Johan On Fri, Feb 16, 2024 at 11:14 PM Kevin Rushforth wrote: > All, > > Even though we build JavaFX binaries with JDK 21 as the boot JDK, the

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-21 Thread John Hendrikx
On Wed, 21 Feb 2024 13:03:46 GMT, Karthik P K wrote: > > To determine the runStart/runEnd, `Text` is already analyzing the runs (and > > doing coordinate tests on them). Runs however have locations, with x/y > > coordinates. Would it not be possible, and more sensible, to adjust the > > `x`,

Re: RFR: 8321603: Bump minimum JDK version for JavaFX to JDK 21 [v2]

2024-02-21 Thread Andy Goryachev
On Wed, 21 Feb 2024 18:39:16 GMT, Kevin Rushforth wrote: >> This PR bumps the minimum version of the JDK needed to run JavaFX to **JDK >> 21**. >> >> In order for JavaFX to be able to use newer JDK features, such as code >> snippets (in API docs), record patterns, pattern matching for switch

Re: RFR: 8321603: Bump minimum JDK version for JavaFX to JDK 21 [v2]

2024-02-21 Thread Kevin Rushforth
> This PR bumps the minimum version of the JDK needed to run JavaFX to **JDK > 21**. > > In order for JavaFX to be able to use newer JDK features, such as code > snippets (in API docs), record patterns, pattern matching for switch > statements, and so forth, we need to increase the minimum

Proposal: RichTextArea Control (Incubator)

2024-02-21 Thread Andy Goryachev
Dear JavaFX developers: We would like to propose a new feature - rich text control, RichTextArea, intended to bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The main design goal is to provide a control that is complete enough to be useful out-of-the box, as well as

Re: RFR: 8321603: Bump minimum JDK version for JavaFX to JDK 21

2024-02-21 Thread Andy Goryachev
On Thu, 15 Feb 2024 20:38:14 GMT, Kevin Rushforth wrote: > This PR bumps the minimum version of the JDK needed to run JavaFX to **JDK > 21**. > > In order for JavaFX to be able to use newer JDK features, such as code > snippets (in API docs), record patterns, pattern matching for switch >

Re: Proposal: JavaFX Incubator Modules

2024-02-21 Thread Philip Race
1) The first thing that jumps out at me is the namespace : javafx.incubator The JDK's JEP 11 says "An incubator module is identified by the|jdk.incubator.|prefix in its module name" It says the same about the packages inside the module. "An incubating API is identified by

Re: Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-21 Thread Kevin Rushforth
Based on feedback, I've moved the PR [1] for this enhancement [2] back to 'rfr'. A Provisional CSR [2] is also ready for review (by one or more people with a "Reviewer" role in the project). Thank you. -- Kevin [1] https://github.com/openjdk/jfx/pull/1370 [2]

Proposal: JavaFX Incubator Modules

2024-02-21 Thread Kevin Rushforth
JEP 11 [1] defines a process for delivering non-final JDK APIs in incubator modules. Similarly, some JavaFX APIs would benefit from spending a period of time in a JavaFX release prior to being deemed stable. I propose JavaFX incubator modules as a means of putting non-final API in the hands

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-21 Thread Karthik P K
On Mon, 19 Feb 2024 14:32:36 GMT, John Hendrikx wrote: > To determine the runStart/runEnd, `Text` is already analyzing the runs (and > doing coordinate tests on them). Runs however have locations, with x/y > coordinates. Would it not be possible, and more sensible, to adjust the `x`, > `y`

Aw: Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-21 Thread Marius Hanl
+1- Marius

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-21 Thread Karthik P K
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation > conditions were not considered, hence hit test values such as character index > and insertion index values were incorrect. > > Added checks for RTL orientation of nodes and fixed the issue in > `getHitInfo()` to