Re: RFR: 8311895: CSS Transitions [v2]

2024-03-18 Thread Michael Strauß
On Mon, 31 Jul 2023 13:44:28 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > Some early feedback, it's a lot of code :) I've implemented @hjohn's suggestion of

Re: RFR: 8311895: CSS Transitions [v11]

2024-03-18 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-scale-x: 1.1; > -fx-scale-y: 1.1; > >

Re: RFR: 8311895: CSS Transitions [v9]

2024-03-18 Thread Michael Strauß
On Tue, 14 Nov 2023 09:41:08 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test whether two Interpolatable instances are compatible > >

Re: RFR: 8311895: CSS Transitions [v10]

2024-03-18 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-scale-x: 1.1; > -fx-scale-y: 1.1; > >

Integrated: 8324326: Update ICU4C to 74.2

2024-03-18 Thread Hima Bindu Meda
On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms This pull request has now been integrated. Changeset: ad3d44e2 Author:Hima Bindu Meda URL:

Integrated: 8327471: RTLTextFlowCharacterIndexTest fails on Linux

2024-03-18 Thread Karthik P K
On Wed, 13 Mar 2024 05:17:40 GMT, Karthik P K wrote: > Because of the difference in the size of characters in default fonts in > different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. > > Increased the scene width to accommodate all the characters as required for > the test to

Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux [v2]

2024-03-18 Thread Andy Goryachev
On Thu, 14 Mar 2024 10:37:26 GMT, Karthik P K wrote: >> Because of the difference in the size of characters in default fonts in >> different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. >> >> Increased the scene width to accommodate all the characters as required for >> the

Re: RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels [v2]

2024-03-18 Thread eduardsdv
On Sun, 17 Mar 2024 18:07:35 GMT, Johan Vos wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511 >> reverted accidental indentation chang > >