Re: RFR: JDK-8186188: TableColumHeader: initial auto-size broken if has graphic [v4]

2024-04-02 Thread Robert Lichtenberger
On Wed, 27 Mar 2024 22:29:02 GMT, Marius Hanl wrote: > @effad Since you benchmarked this method in #1358, could you do that again > with this changes? Sorry for the late reply, I just returned from easter holidays :-). I'll try to benchmark this change within the next days... - P

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v3]

2024-04-02 Thread eduardsdv
> This change fixes the calculation of which nodes go to the toolbar and which > go to the overflow menu. > It is now determined before the nodes are removed from the scene graph. > This is important because the values returned by > ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whe

Re: RFR: JDK-8186188: TableColumHeader: initial auto-size broken if has graphic [v7]

2024-04-02 Thread Robert Lichtenberger
On Wed, 27 Mar 2024 23:20:49 GMT, Marius Hanl wrote: >> This PR fixes the issue that the initial column autosizing is wrong under >> some circumstances. >> The following things will break the initial autosizing: >> - Bold Column text (that is where I initially found this problem) >> - Another fo

Re: [openjdk/jfx] Draft: Prefer EGL over GLX to allow further development towards Wayland (PR #1381)

2024-04-02 Thread Thiago Milczarek SayĆ£o
Thanks Lukasz. ll look into the points brought up. I'm unsure on scenarios where GLX will work and EGL will not, but Gtk has GLX fallback. I will look into it (maybe ask on a Mesa development channel). The force flag is a nice idea. It's not a formal JBS issue yet because I don't know if it fits

Re: RFR: 8328752: Fix missing @Overrides in javafx.web

2024-04-02 Thread Kevin Rushforth
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. These changes look good. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jf

Re: RFR: JDK-8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v3]

2024-04-02 Thread Lukasz Kostyra
On Sat, 9 Mar 2024 18:41:10 GMT, Marius Hanl wrote: >> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` >> is broken when `sizeToScene()` was called before or after. >> >> The approach here is to ignore the `sizeToScene()` request when the `Stage` >> is maximized or s

Re: RFR: 8328742: Remove unused imports in manual tests

2024-04-02 Thread Andy Goryachev
On Thu, 21 Mar 2024 19:51:22 GMT, Kevin Rushforth wrote: >> Using Eclipse IDE to remove unused imports in **manual tests** and update >> the copyright year to 2024. Using wildcard for more than 10 static imports. >> >> >> >> -- >> >> This is a trivial change, 1 reviewer is probably enough. >

Re: RFR: 8328742: Remove unused imports in manual tests

2024-04-02 Thread Andy Goryachev
On Thu, 21 Mar 2024 19:38:38 GMT, Andy Goryachev wrote: > Using Eclipse IDE to remove unused imports in **manual tests** and update the > copyright year to 2024. Using wildcard for more than 10 static imports. > > > > -- > > This is a trivial change, 1 reviewer is probably enough. @aghaisas

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming

2024-04-02 Thread Kevin Rushforth
On Tue, 2 Apr 2024 00:18:04 GMT, Alexander Matveev wrote: > - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. > - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR > for more details): > - MP2T streams with one H.264/AVC video track and elementary AAC audio

Re: RFR: 8328742: Remove unused imports in manual tests

2024-04-02 Thread Kevin Rushforth
On Thu, 21 Mar 2024 19:38:38 GMT, Andy Goryachev wrote: > Using Eclipse IDE to remove unused imports in **manual tests** and update the > copyright year to 2024. Using wildcard for more than 10 static imports. > > > > -- > > This is a trivial change, 1 reviewer is probably enough. I'm alrea

Re: RFR: 8328742: Remove unused imports in manual tests

2024-04-02 Thread Kevin Rushforth
On Thu, 21 Mar 2024 19:38:38 GMT, Andy Goryachev wrote: > Using Eclipse IDE to remove unused imports in **manual tests** and update the > copyright year to 2024. Using wildcard for more than 10 static imports. > > > > -- > > This is a trivial change, 1 reviewer is probably enough. Marked as

Integrated: 8328742: Remove unused imports in manual tests

2024-04-02 Thread Andy Goryachev
On Thu, 21 Mar 2024 19:38:38 GMT, Andy Goryachev wrote: > Using Eclipse IDE to remove unused imports in **manual tests** and update the > copyright year to 2024. Using wildcard for more than 10 static imports. > > > > -- > > This is a trivial change, 1 reviewer is probably enough. This pull

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v12]

2024-04-02 Thread Andy Goryachev
> Modified the resize algorithm to work well with fractional scale, thanks for > deeper understanding of the problem thanks to @hjohn and @mstr2 . > > Removed earlier manual tester in favor of the monkey tester. > > It is important to note that even though the constraints are given by the > us