On Wed, 3 Apr 2024 19:54:20 GMT, Jose Pereda wrote:
>> This PR fixes the issue that after committing an edit on a
>> ListView/TreeView/TableView/TreeTableView control, the control might lose
>> the focus unexpectedly.
>>
>> For that, it refactors the
>>
> This PR fixes the issue that after committing an edit on a
> ListView/TreeView/TableView/TreeTableView control, the control might lose the
> focus unexpectedly.
>
> For that, it refactors the
> `ControlUtils::requestFocusOnControlOnlyIfCurrentFocusOwnerIsChild` method,
> in order to check
On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewer
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java
>
On Wed, 3 Apr 2024 18:53:08 GMT, Andy Goryachev wrote:
> Hi all,
>
> This pull request contains a backport of commit
>
Hi all,
This pull request contains a backport of commit
[483c6408](https://urldefense.com/v3/__https://github.com/openjdk/jfx/commit/483c64082f7752e239c5630eb1d7895e599e5dda__;!!ACWV5N9M2RV99hQ!M-G018UM97QRsj9teiPLnY-Cdm4FuyCwtrHfyQodu1pJVqB6O1X9nx8G-xSgI9garjnyTYhFbukpa-9-Sfb6b7kZJpzddg$)
from
On Wed, 20 Mar 2024 10:55:56 GMT, Jose Pereda wrote:
> This PR fixes the issue that after committing an edit on a
> ListView/TreeView/TableView/TreeTableView control, the control might lose the
> focus unexpectedly.
>
> For that, it refactors the
>
On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl wrote:
>> This PR fixes the issue that after committing an edit on a
>> ListView/TreeView/TableView/TreeTableView control, the control might lose
>> the focus unexpectedly.
>>
>> For that, it refactors the
>>
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote:
> Fix missing @Overrides in **javafx.web**.
>
> This is still a trivial change since all the spots are identified by the IDE.
This pull request has now been integrated.
Changeset: 483c6408
Author:Andy Goryachev
URL:
On Wed, 3 Apr 2024 17:45:46 GMT, Hima Bindu Meda wrote:
>> Fix missing @Overrides in **javafx.web**.
>>
>> This is still a trivial change since all the spots are identified by the IDE.
>
> Changes look good
thank you @HimaBinduMeda !
-
PR Comment:
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote:
> Fix missing @Overrides in **javafx.web**.
>
> This is still a trivial change since all the spots are identified by the IDE.
Changes look good
-
Marked as reviewed by hmeda (Committer).
PR Review:
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
11 matches
Mail list logo