Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Andy Goryachev
On Wed, 3 Apr 2024 19:54:20 GMT, Jose Pereda wrote: >> This PR fixes the issue that after committing an edit on a >> ListView/TreeView/TableView/TreeTableView control, the control might lose >> the focus unexpectedly. >> >> For that, it refactors the >>

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Jose Pereda
> This PR fixes the issue that after committing an edit on a > ListView/TreeView/TableView/TreeTableView control, the control might lose the > focus unexpectedly. > > For that, it refactors the > `ControlUtils::requestFocusOnControlOnlyIfCurrentFocusOwnerIsChild` method, > in order to check

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Jose Pereda
On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback from reviewer > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java >

[jfx22u] Integrated: 8328752: Fix missing @Overrides in javafx.web

2024-04-03 Thread Andy Goryachev
On Wed, 3 Apr 2024 18:53:08 GMT, Andy Goryachev wrote: > Hi all, > > This pull request contains a backport of commit >

[jfx22u] RFR: 8328752: Fix missing @Overrides in javafx.web

2024-04-03 Thread Andy Goryachev
Hi all, This pull request contains a backport of commit [483c6408](https://urldefense.com/v3/__https://github.com/openjdk/jfx/commit/483c64082f7752e239c5630eb1d7895e599e5dda__;!!ACWV5N9M2RV99hQ!M-G018UM97QRsj9teiPLnY-Cdm4FuyCwtrHfyQodu1pJVqB6O1X9nx8G-xSgI9garjnyTYhFbukpa-9-Sfb6b7kZJpzddg$) from

Re: RFR: 8324939: Editable TableView loses focus after commit

2024-04-03 Thread Andy Goryachev
On Wed, 20 Mar 2024 10:55:56 GMT, Jose Pereda wrote: > This PR fixes the issue that after committing an edit on a > ListView/TreeView/TableView/TreeTableView control, the control might lose the > focus unexpectedly. > > For that, it refactors the >

Re: RFR: 8324939: Editable TableView loses focus after commit

2024-04-03 Thread Andy Goryachev
On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl wrote: >> This PR fixes the issue that after committing an edit on a >> ListView/TreeView/TableView/TreeTableView control, the control might lose >> the focus unexpectedly. >> >> For that, it refactors the >>

Integrated: 8328752: Fix missing @Overrides in javafx.web

2024-04-03 Thread Andy Goryachev
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. This pull request has now been integrated. Changeset: 483c6408 Author:Andy Goryachev URL:

Re: RFR: 8328752: Fix missing @Overrides in javafx.web

2024-04-03 Thread Andy Goryachev
On Wed, 3 Apr 2024 17:45:46 GMT, Hima Bindu Meda wrote: >> Fix missing @Overrides in **javafx.web**. >> >> This is still a trivial change since all the spots are identified by the IDE. > > Changes look good thank you @HimaBinduMeda ! - PR Comment:

Re: RFR: 8328752: Fix missing @Overrides in javafx.web

2024-04-03 Thread Hima Bindu Meda
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. Changes look good - Marked as reviewed by hmeda (Committer). PR Review:

Re: RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels [v2]

2024-04-03 Thread eduardsdv
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top.