Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote: >> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >>

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v5]

On Mon, 15 Apr 2024 15:42:27 GMT, eduardsdv wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java >> line 575: >> >>> 573: box.getStyleClass().addListener((ListChangeListener>> String>) change ->

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v5]

On Mon, 15 Apr 2024 15:24:06 GMT, Andy Goryachev wrote: >> eduardsdv has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - JDK-8328577: Update comment >> - JDK-8328577: Bind style related properties > >

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v5]

On Mon, 15 Apr 2024 15:10:42 GMT, Andy Goryachev wrote: >> eduardsdv has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - JDK-8328577: Update comment >> - JDK-8328577: Bind style related properties > >

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v6]

> This change fixes the calculation of which nodes go to the toolbar and which > go to the overflow menu. > It is now determined before the nodes are removed from the scene graph. > This is important because the values returned by > ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v5]

On Mon, 15 Apr 2024 12:38:15 GMT, eduardsdv wrote: >> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >>

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

On Mon, 15 Apr 2024 12:28:55 GMT, eduardsdv wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java >> line 783: >> >>> 781: CustomMenuItem customMenuItem = new >>> CustomMenuItem(node); >>> 782: >>> 783: // RT-36455:

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

On Fri, 12 Apr 2024 18:11:14 GMT, Andy Goryachev wrote: >> eduardsdv has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane > >

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v5]

> This change fixes the calculation of which nodes go to the toolbar and which > go to the overflow menu. > It is now determined before the nodes are removed from the scene graph. > This is important because the values returned by > ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v4]

On Fri, 12 Apr 2024 18:15:41 GMT, Andy Goryachev wrote: >> eduardsdv has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8328577: Collect overflowed items in a shadow (overflowBox) pane > >

Re: RFR: 8092102: Labeled: truncated property [v9]

On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote: >> Adds **Labeled.textTruncated** property which indicates when the text is >> visually truncated (and the ellipsis string is inserted) in order to fit the >> available width. >> >> The new property reacts to changes in the following

Re: RFR: 8092102: Labeled: truncated property [v8]

On Wed, 10 Apr 2024 21:28:16 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java >> line 38: >> >>> 36: /** >>> 37: * Returns true when the Labeled must compute the actual >>> content width in computePrefWidth().