Re: RFR: 8092102: Labeled: truncated property [v14]

2024-05-03 Thread Andy Goryachev
On Fri, 3 May 2024 21:00:26 GMT, Andy Goryachev wrote: >> Adds **Labeled.textTruncated** property which indicates when the text is >> visually truncated (and the ellipsis string is inserted) in order to fit the >> available width. >> >> The new property is being set by the code which computes

Re: RFR: 8092102: Labeled: truncated property [v14]

2024-05-03 Thread Andy Goryachev
> Adds **Labeled.textTruncated** property which indicates when the text is > visually truncated (and the ellipsis string is inserted) in order to fit the > available width. > > The new property is being set by the code which computes the actual text > string to be displayed (and which inserts t

Re: RFR: 8092102: Labeled: truncated property [v13]

2024-05-03 Thread Andy Goryachev
> Adds **Labeled.textTruncated** property which indicates when the text is > visually truncated (and the ellipsis string is inserted) in order to fit the > available width. > > The new property is being set by the code which computes the actual text > string to be displayed (and which inserts t

Re: RFR: 8092102: Labeled: truncated property [v11]

2024-05-03 Thread Andy Goryachev
On Fri, 3 May 2024 13:19:17 GMT, Kevin Rushforth wrote: > Would it be possible to set the value of the truncated property at the point > where truncation occurs? yes, `LabeledSkinBase.updateDisplayedText()` determines whether the text is truncated or not. - PR Review Comment: htt

Re: RFR: 8092102: Labeled: truncated property [v12]

2024-05-03 Thread Andy Goryachev
> Adds **Labeled.textTruncated** property which indicates when the text is > visually truncated (and the ellipsis string is inserted) in order to fit the > available width. > > The new property reacts to changes in the following properties: > - ellipsisString > - font > - height > - text > - wid

RFR: 8331616: ChangeListener is not triggered when the InvalidationListener is removed

2024-05-03 Thread John Hendrikx
This PR provides a fix for the linked issue. The issue was that when an invalidation listener is removed, and the `ExpressionHelper` type changes from `Generic` to `SingleChange` that it would copy the current value of the `Generic` instance before it was updated (this is because invalidation l

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v12]

2024-05-03 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they were registered, invalidation listeners > always before ch

Re: RFR: 8092102: Labeled: truncated property [v11]

2024-05-03 Thread Kevin Rushforth
On Thu, 2 May 2024 22:10:24 GMT, Andy Goryachev wrote: >> Adds **Labeled.textTruncated** property which indicates when the text is >> visually truncated (and the ellipsis string is inserted) in order to fit the >> available width. >> >> The new property reacts to changes in the following prope

Re: RFR: 8092102: Labeled: truncated property [v11]

2024-05-03 Thread Kevin Rushforth
On Thu, 2 May 2024 22:10:24 GMT, Andy Goryachev wrote: >> Adds **Labeled.textTruncated** property which indicates when the text is >> visually truncated (and the ellipsis string is inserted) in order to fit the >> available width. >> >> The new property reacts to changes in the following prope

Re: RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

2024-05-03 Thread eduardsdv
On Wed, 13 Mar 2024 09:13:20 GMT, Florian Kirmaier wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> reverted accidental change in the .idea folder > > *push* > It's still a important bug. > If someone can guide

Re: RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v5]

2024-05-03 Thread Florian Kirmaier
> In some situations, a part of the SG is no longer rendered. > I created a test program that showcases this problem. > > Explanation: > > This can happen, when a part of the SG, is covered by another Node. > In this part, one node is totally covered, and the other node is visible. > > When the

Integrated: 8271865: SortedList::getViewIndex behaves not correctly for some index values

2024-05-03 Thread drmarmac
On Sun, 24 Mar 2024 15:11:29 GMT, drmarmac wrote: > This PR adds the missing checks, as well as code documentation that an > IndexOutOfBoundsException may be thrown. This pull request has now been integrated. Changeset: 54005125 Author:drmarmac <6900949+drmar...@users.noreply.github.com> C

Re: RFR: 8271865: SortedList::getViewIndex behaves not correctly for some index values [v3]

2024-05-03 Thread Lukasz Kostyra
On Thu, 2 May 2024 13:12:09 GMT, drmarmac wrote: >> This PR adds the missing checks, as well as code documentation that an >> IndexOutOfBoundsException may be thrown. > > drmarmac has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes t