Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v4]

2024-05-08 Thread Alexander Matveev
> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. > - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR > for more details): > - MP2T streams with one H.264/AVC video track and elementary AAC audio > stream via #EXT-X-MEDIA tag. > - fMP4 streams with one

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Wed, 8 May 2024 12:26:06 GMT, Kevin Rushforth wrote: >> modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 123: >> >>> 121: >>> "(Lcom/sun/media/jfxmedia/locator/ConnectionHolder;)Lcom/sun/media/jfxmedia/locator/ConnectionHolder;"); >>> 122:

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Tue, 7 May 2024 19:54:52 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2] > >

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Wed, 8 May 2024 12:39:24 GMT, Kevin Rushforth wrote: >> When these classes were nested classes I got issues with second instance of >> HLSConnectionHolder. If I remember correctly nested classes of second >> instance of HLSConnectionHolder were using fields of first >> HLSConnectionHolder

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Alexander Matveev
On Fri, 26 Apr 2024 23:36:26 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video track and elementary AAC

Proposed schedule for JavaFX 23

2024-05-08 Thread Kevin Rushforth
Here is the proposed schedule for JavaFX 23. RDP1: Jul 11, 2024 (aka “feature freeze”) RDP2: Aug 1, 2024 Freeze: Aug 29, 2024 GA: Sep 17, 2024 We plan to fork a jfx23 stabilization branch at RDP1. The start of RDP1, the start of RDP2, and the code freeze will be 16:00 UTC on the respective

Re: RFR: 8330590: TextInputControl: previous word fails with Bhojpuri characters [v2]

2024-05-08 Thread Andy Goryachev
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote: >> This change replaces Character.isLetterOrDigit(char) which fails with >> surrogate characters with Character.isLetterOrDigit(int). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase.

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v26]

2024-05-08 Thread Kevin Rushforth
On Wed, 8 May 2024 13:56:43 GMT, Oliver Kopp wrote: > Looking forward to the next JavaFX release where this fix is included! It should be available in the next EA build of JavaFX 23. @arapte will backport it to jfx22u for JavaFX 22.0.2. - PR Comment:

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v26]

2024-05-08 Thread Andy Goryachev
On Wed, 8 May 2024 13:56:43 GMT, Oliver Kopp wrote: >>>Thank you. I committed at >>>https://github.com/openjdk/jfx/commit/d03bdd40a3340bd85397fe2ceaa7f053a58da6c5 >>> (with you as author, hope this is in line with the policies?!). >> >> Thanks @koppor, the fix looks good. >> That's a great

Integrated: 8092102: Labeled: textTruncated property

2024-05-08 Thread Andy Goryachev
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote: > Adds **Labeled.textTruncated** property which indicates when the text is > visually truncated (and the ellipsis string is inserted) in order to fit the > available width. > > The new property is being set by the code which computes the

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v26]

2024-05-08 Thread Oliver Kopp
On Tue, 7 May 2024 06:32:58 GMT, Ambarish Rapte wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Streamline WinTextRangeProviderTest >> >> Source: >>

Integrated: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-08 Thread Oliver Kopp
On Thu, 18 Apr 2024 12:01:52 GMT, Oliver Kopp wrote: > Fixes https://bugs.openjdk.org/browse/JDK-8330462. > > If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then > an addition of `start` to it leads to a negative value. This is "fixed" by > using `Math.max` comparing

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Kevin Rushforth
On Wed, 8 May 2024 02:31:08 GMT, Alexander Matveev wrote: >> modules/javafx.media/src/main/java/com/sun/media/jfxmedia/locator/HLSConnectionHolder.java >> line 480: >> >>> 478: } >>> 479: >>> 480: class PlaylistLoader extends Thread { >> >> Having multiple top-level classes in the same

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Kevin Rushforth
On Wed, 8 May 2024 06:00:30 GMT, Ambarish Rapte wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2] > >

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v25]

2024-05-08 Thread Kevin Rushforth
On Thu, 2 May 2024 23:32:19 GMT, Oliver Kopp wrote: >> The fix looks good, I have few comments about the test. >> 1. The test does not compile without fix, hence it won't fail without fix as >> we are only testing the newly added helper method. >> 2. It is not required to change the error

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-05-08 Thread Ambarish Rapte
On Fri, 26 Apr 2024 23:36:26 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video track and elementary AAC