Re: RFR: 8331748: Update libxml2 to 2.12.6

2024-05-13 Thread Johan Vos
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.6. Verified build and sanity testing on all > platforms. No issue seen @tiainen can you do a build/review? - PR Comment: https://git.openjdk.org/jfx/pull/1453#issuecomment-2109378318

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-13 Thread robbiezl
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

RFR: 8331748: Update libxml2 to 2.12.6

2024-05-13 Thread Hima Bindu Meda
Updated libxml to v2.12.6. Verified build and sanity testing on all platforms. No issue seen - Commit messages: - whitespace correction - update md file - Configure libxml on windows - configure libxml on linux - add missing headers - Update libxml to v2.12.6 Changes: https://

Re: RFR: 8291908: VirtualFlow creates unneeded empty cells

2024-05-13 Thread smith3390s
On Thu, 4 Aug 2022 14:30:40 GMT, Johan Vos wrote: > When calculating the viewportOffset, we now already take into account that > cells will have to shift. > > This prevents the creation of temporary empty cells in the layout phase. > One test needed to be fixed, since the number of invocations

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Kevin Rushforth
On Mon, 13 May 2024 17:26:02 GMT, Ambarish Rapte wrote: >> Ah, I see. In that case, reordering to match mainline seems good. > > May be I am missing something here, > I verified the order, it is same as mainline jfx. (jfx has 3 more, that > follow the new addition) In that case, my earlier comm

[jfx22u] Integrated: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Ambarish Rapte
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote: > The backport is almost clean. > While cherry picking the mainline commit, a minor merge conflict was shown in > a the file `tests/system/src/test/.classpath` : The mainline file has a few > additional exports compared to 22u. > > Test p

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Ambarish Rapte
On Mon, 13 May 2024 16:42:05 GMT, Kevin Rushforth wrote: >> forgot to mention the diff is just a different ordering. > > Ah, I see. In that case, reordering to match mainline seems good. May be I am missing something here, I verified the order, it is same as mainline jfx. (jfx has 3 more, that f

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Kevin Rushforth
On Mon, 13 May 2024 16:39:43 GMT, Andy Goryachev wrote: >> Probably not as part of this backport. Also, the fact that they are >> different suggests that there might be another fix that is in mainline but >> not in jfx22u (and we wouldn't choose to backport another fix just to avoid >> a merge

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Andy Goryachev
On Mon, 13 May 2024 15:54:47 GMT, Kevin Rushforth wrote: >> tests/system/src/test/.classpath line 17: >> >>> 15: >>> 16: >>> 17: >> value="javafx.graphics/com.sun.glass.ui=ALL-UNNAMED:javafx.graphics/com.sun.glass.ui.monocle=ALL-U

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Andy Goryachev
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote: > The backport is almost clean. > While cherry picking the mainline commit, a minor merge conflict was shown in > a the file `tests/system/src/test/.classpath` : The mainline file has a few > additional exports compared to 22u. > > Test p

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Kevin Rushforth
On Mon, 13 May 2024 15:13:20 GMT, Andy Goryachev wrote: >> The backport is almost clean. >> While cherry picking the mainline commit, a minor merge conflict was shown >> in a the file `tests/system/src/test/.classpath` : The mainline file has a >> few additional exports compared to 22u. >> >>

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Kevin Rushforth
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote: > The backport is almost clean. > While cherry picking the mainline commit, a minor merge conflict was shown in > a the file `tests/system/src/test/.classpath` : The mainline file has a few > additional exports compared to 22u. > > Test p

Re: [jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Andy Goryachev
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote: > The backport is almost clean. > While cherry picking the mainline commit, a minor merge conflict was shown in > a the file `tests/system/src/test/.classpath` : The mainline file has a few > additional exports compared to 22u. > > Test p

Withdrawn: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Scr

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 12 May 2024 11:03:36 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

Withdrawn: 8329820: [Linux] Prefer EGL over GLX

2024-05-13 Thread Thiago Milczarek Sayao
On Sat, 24 Feb 2024 17:54:47 GMT, Thiago Milczarek Sayao wrote: > Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: > [Switching the Linux

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v13]

2024-05-13 Thread Andy Goryachev
On Fri, 12 Apr 2024 22:47:21 GMT, Andy Goryachev wrote: >> Modified the resize algorithm to work well with fractional scale, thanks for >> deeper understanding of the problem thanks to @hjohn and @mstr2 . >> >> Removed earlier manual tester in favor of the monkey tester. >> >> It is important

[jfx22u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-13 Thread Ambarish Rapte
The backport is almost clean. While cherry picking the mainline commit, a minor merge conflict was shown in a the file `tests/system/src/test/.classpath` : The mainline file has a few additional exports compared to 22u. Test passes on windows. - Commit messages: - 8330462: StringI

Re: RFR: 8313138: Scrollbar Keyboard enhancement [v7]

2024-05-13 Thread Ambarish Rapte
On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev wrote: >> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key >> bindings to >> >> - ListView >> - TreeView >> - TableView >> - TreeTableView >> >> to support keyboard-only horizontal and vertical scrolling. The main reaso