On Sat, 18 May 2024 14:24:49 GMT, Kevin Rushforth wrote:
> Maybe it's worth changing "adds any new" to "adds, removes, or modifies any"?
This looks like a good idea.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605798488
On Fri, 17 May 2024 15:02:14 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 additional
>> commits
On Fri, 17 May 2024 12:36:22 GMT, Florian Kirmaier
wrote:
> Sorry for creating the CSR, it was an accident.
No problem.
> Now that Eduard has both created an alternative solution, but also has
> reviewed that this solution is correct, and provided an unit-test - I think
> this (or the other)
On Fri, 17 May 2024 13:46:12 GMT, eduardsdv wrote:
> > I'm only wondering if the code in `paintImpl` should always clear the dirty
> > bits even if an exception occurs during painting, to harden it against
> > potential bugs and not end up trying to repaint again and again likely
> > getting t
