On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen
Code changes look good. Tests are green.
-
Marked as reviewed by kcr (Lead).
PR Review:
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen
-
Commit messages:
- configure libxml on windows
- configure libxml on linux
- update libxml to v2.12.7
Changes: https://git.openjdk.org/jfx/pull/1464/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1464=00
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen
Reviewers: @kevinrushforth @tiainen
-
PR Comment: https://git.openjdk.org/jfx/pull/1464#issuecomment-2130131350
On Thu, 23 May 2024 14:01:40 GMT, Marius Hanl wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog`
>> is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage`
>> is maximized or
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to
On Thu, 23 May 2024 15:22:38 GMT, Kevin Rushforth wrote:
> [JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
> support to javadoc, using `///` to indicate markdown documentation comments.
> As a result, building JavaFX docs with JDK 23 produces new warnings, which
>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
All,
If you have backports that you want to get into jfx22u for JavaFX
22.0.2, please do so by Monday, June 10th. Note that approval from one
of the project leads is needed as outlined in this message [1].
Thanks.
-- Kevin
[1]
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Fri, 24 May 2024 12:12:27 GMT, Kevin Rushforth wrote:
> > > I wonder if we may want to add some tests for the `FixedCapacitySet`?
> >
> >
> > Yeah, now that it is more likely that this will make it into FX, I will add
> > a small set of unit tests for this class.
>
> Since this PR is
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Fri, 24 May 2024 06:48:50 GMT, Jayathirth D V wrote:
> In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag
> is not defined and we don't see any issue) to enable printing of memory
> statistics log. But if we enable it, we get crash while disposing IJG stored
>
On Fri, 24 May 2024 08:22:28 GMT, John Hendrikx wrote:
> > I wonder if we may want to add some tests for the `FixedCapacitySet`?
>
> Yeah, now that it is more likely that this will make it into FX, I will add a
> small set of unit tests for this class.
Since this PR is ready to integrate, I
On Fri, 24 May 2024 10:15:37 GMT, drmarmac wrote:
> * Attempting to do background-color transitions doesn't work, I presume
> because it's not yet `Interpolatable` in this PR. Do we need to emit a
> warning in such a case? Right now the `transition` CSS code just seems to be
> ignored.
CSS
On Fri, 24 May 2024 10:02:44 GMT, drmarmac wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 53 commits:
>>
>> - Merge branch 'master' into feature/css-transitions
>> - update 'since' tags
>> - Fix
> Implementation of [CSS
> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>
> ### Future enhancements
> CSS transitions requires all participating objects to implement the
> `Interpolatable` interface. For example, targeting `-fx-background-color`
> only works if
On Thu, 2 May 2024 08:40:28 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable` interface.
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window
On Thu, 23 May 2024 22:54:15 GMT, Marius Hanl wrote:
> Code looks good to me. As mentioned above, I tested it already and everything
> was good, so I'm certain that there is no regression here.
>
> I'm generally not a big fan of 'reimplementing' Collections, but I can see
> why it is needed
On Thu, 23 May 2024 22:44:08 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move getStyleClassNames to location it was introduced to reduce diff
>
>
In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag is
not defined and we don't see any issue) to enable printing of memory statistics
log. But if we enable it, we get crash while disposing IJG stored objects in
jmemmgr->free-pool() function.
#
# A fatal error has
23 matches
Mail list logo
