Re: CFV: New OpenJFX Reviewer: John Hendrikx

2024-05-26 Thread Ajit Ghaisas
Vote: YES Regards, Ajit > On 23-May-2024, at 4:54 AM, Kevin Rushforth > wrote: > > I hereby nominate John Hendrikx [1] to OpenJFX Reviewer. > > John is an OpenJFX community member, who has contributed 39 commits [2] to > OpenJFX. John regularly participates in code reviews, especially in the

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v5]

2024-05-26 Thread Marius Hanl
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is > broken when `sizeToScene()` was called before or after. > > The approach here is to ignore the `sizeToScene()` request when the `Stage` > is maximized or set to fullscreen. > Otherwise the Window Manager of the OS

Re: RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v6]

2024-05-26 Thread Marius Hanl
> This PR fixes a long standing issue where the `Tooltip` will always wait one > second until it appears the very first time, even if the > `-fx-show-delay` was set to another value. > > The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside > the `TooltipBehaviour`. So t

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling

2024-05-26 Thread Marius Hanl
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote: > Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not > modify the layout of `VirtualFlow`. > > This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, > which made many calculations leading to floa

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v2]

2024-05-26 Thread Marius Hanl
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not > modify the layout of `VirtualFlow`. > > This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, > which made many calculations leading to floating point errors. > Interestingly I found out, that `g

Re: RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v5]

2024-05-26 Thread Marius Hanl
On Thu, 23 May 2024 22:30:29 GMT, Andy Goryachev wrote: > with the latest monkey tester I see that updating the stylesheet does not > update the showingDelay property immediately. When the tooltip gets shown, I > see the following output from the change listener added to this property: > > ```

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling

2024-05-26 Thread Marius Hanl
On Fri, 24 May 2024 16:59:20 GMT, Andy Goryachev wrote: >> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not >> modify the layout of `VirtualFlow`. >> >> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, >> which made many calculations leading

Re: CFV: New OpenJFX Reviewer: John Hendrikx

2024-05-26 Thread Nir Lisker
Resending the vote on the mailing list because I sent it only to Kevin. Vote: YES On Thu, May 23, 2024 at 2:38 AM Nir Lisker wrote: > Vote: YES > > On Thu, May 23, 2024 at 2:24 AM Kevin Rushforth < > kevin.rushfo...@oracle.com> wrote: > >> I hereby nominate John Hendrikx [1] to OpenJFX Reviewer

Re: RFR: 8311895: CSS Transitions [v20]

2024-05-26 Thread Nir Lisker
On Sun, 26 May 2024 08:08:26 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the >> `Interpolatable` interface.

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-26 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 22:02:33 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

Re: RFR: 8311895: CSS Transitions [v20]

2024-05-26 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color` > only works if

Re: RFR: 8311895: CSS Transitions [v19]

2024-05-26 Thread Michael Strauß
On Sat, 25 May 2024 23:19:03 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added documentation > > modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line > 749: > >> 747