On Mon, 6 May 2024 14:14:05 GMT, eduardsdv wrote:
> This is an alternative solution to the PR:
> https://github.com/openjdk/jfx/pull/1310.
>
> This solution is based on the invariant that if a node is marked as dirty,
> all ancestors must also be marked as dirty and that if an ancestor is mark
On Thu, 27 Jun 2024 20:22:24 GMT, Markus Mack wrote:
> This PR fixes the placement of `BarChart` bars and category tick marks,
> particularly when adding data / multiple series and enabling animations.
> It covers all cases mentioned in the JBS ticket and adds a unit test.
>
> The settable `bar
This PR fixes the placement of `BarChart` bars and category tick marks,
particularly when adding data / multiple series and enabling animations.
It covers all cases mentioned in the JBS ticket and adds a unit test.
The settable `barGap` and `categoryGap` now should also behave as expected.
There
I'm not sure why Skara is replaying some old RFR messages from last year
and earlier this year. It's either a glitch, or the bot is finally
sending old messages that were not sent earlier for some reason.
-- Kevin
On Mon, 24 Jun 2024 22:10:38 GMT, Markus Mack wrote:
> This PR is a fix for another IOOBE that I discovered while working on #1476.
>
> The PR simplifies the code for adding a series that already contains data by
> adding the data points one-by-one.
> As far as I can see no attempt was previous
On Sun, 16 Apr 2023 17:20:08 GMT, Michael Strauß wrote:
>> While looking that code over to see if it could be merged without impacting
>> the general case, I discovered a small bug in the OldValueCaching version.
>> After I fixed it, the code was even more similar than it was already. The
>>
On Sun, 16 Apr 2023 12:34:44 GMT, John Hendrikx wrote:
>> I agree with you there, and I've been looking what would be a good way to
>> achieve this. I will take another look soon. My primary concern is that
>> this is a somewhat critical path, and I would want to ensure that it doesn't
>> ca
On Wed, 5 Jul 2023 20:31:09 GMT, Michael Strauß wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Mon, 24 Jul 2023 22:09:49 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerManager.java
>> line 143:
>>
>>> 141: */
>>> 142: public void fireValueChanged(I instance, T oldValue) {
>>> 143: Object data = getData(instance);
>>
>> T
On Thu, 8 Feb 2024 21:25:41 GMT, Marius Hanl wrote:
> I completely forgot about this PR, but it looks very interesting, especially
> about the nested events. If helpful, I can test this soon in a bigger
> application, especially for any regressions. And of course also review the
> code, but ne
On Thu, 6 Jul 2023 00:23:09 GMT, Michael Strauß wrote:
>> I agree with John that a layout algorithm that uses incremental calculations
>> will always be flawed in principle. The correct approach is to store the
>> initial configuration, and then for each configuration change, go back to
>> the
On Sun, 16 Apr 2023 07:43:05 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerList.java
>> line 101:
>>
>>> 99: * notification otherwise {@code false}
>>> 100: */
>>> 101: public boolean notifyListeners(ObservableValu
On Mon, 25 Mar 2024 13:32:11 GMT, Michael Strauß wrote:
> `ListenerManager` is an obvious improvement, as it fixes incorrect behavior
> and allows listeners to veto changes. However, the behavior of
> `ListenerManager` is also an implementation detail and not documented
> anywhere. This leads
On Thu, 27 Jun 2024 13:43:37 GMT, Marius Hanl wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog`
>> is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage`
>> is maximized or
On Fri, 30 Jun 2023 05:38:35 GMT, Karthik P K wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important to
On Thu, 13 Apr 2023 15:58:32 GMT, Nir Lisker wrote:
> John and I discussed this off-list. I will write a short review of this
> change.
I have some small corrections I think.
> * Nested events are invoked "depth-first", meaning that the parent event
> propagation is halted until the nested ev
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
On Wed, 5 Jul 2023 20:31:09 GMT, Michael Strauß wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in favor of the monkey tester.
>>
>> It is important
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
This provides and uses a new implementation of `ExpressionHelper`, called
`ListenerManager` with improved semantics.
# Behavior
|Listener...|ExpressionHelper|ListenerManager|
|---|---|---|
|Invocation Order|In order they were registered, invalidation listeners always
before change listeners|(un
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
On Sun, 2 Jul 2023 12:53:05 GMT, John Hendrikx wrote:
> My observation is that this algorithm seems unable to provide a proper user
> resizing experience as it seems to discard important information it would
> need to do so.
please elaborate, or point to a specific problem. It is entirely pos
On Tue, 27 Jun 2023 18:23:29 GMT, Andy Goryachev wrote:
> @hjohn would you mind taking a look at this? using the ideas from your
> SpaceDistributor
Will take a look this weekend
-
PR Comment: https://git.openjdk.org/jfx/pull/1156#issuecomment-1614422355
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
Modified the resize algorithm to work well with fractional scale, thanks for
deeper understanding of the problem thanks to @hjohn and @mstr2 .
Removed earlier manual tester in favor of the monkey tester.
It is important to note that even though the constraints are given by the user
in unsnappe
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc, clarifying
On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote:
>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
>> mark layout code in subclasses) is called during `Chart` `Axis` layout when
>> needed.
>> Previously, it was only called when tick mark length or range was chang
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote:
> This problem has been fixed
> [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges
> the fix in advance.
>
> Error log:
>
>
> /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2:
> erro
On Fri, 21 Jun 2024 16:57:38 GMT, Markus Mack wrote:
>> This PR makes the `XYChart` axes properties return the correct parent
>> XYChart object.
>
> Markus Mack has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Set correct bean for propertie
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is
> broken when `sizeToScene()` was called before or after.
>
> The approach here is to ignore the `sizeToScene()` request when the `Stage`
> is maximized or set to fullscreen.
> Otherwise the Window Manager of the OS
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote:
> This problem has been fixed
> [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges
> the fix in advance.
>
> Error log:
>
>
> /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2:
> erro
On Thu, 27 Jun 2024 10:38:42 GMT, Lukasz Kostyra wrote:
> Change looks good, but I'm still seeing failures on my macOS system (Sonoma
> 14.5, MacBook Pro M1 Max):
I'm confused, the screen height is reported as 1085? Looks like the width, but
I still would not expect a width like that. Thats wh
On Tue, 25 Jun 2024 08:01:49 GMT, Marius Hanl wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog`
>> is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage`
>> is maximized or
On Tue, 25 Jun 2024 08:01:49 GMT, Marius Hanl wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog`
>> is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage`
>> is maximized or
On Fri, 21 Jun 2024 11:24:34 GMT, Kevin Rushforth wrote:
>> This problem has been fixed
>> [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges
>> the fix in advance.
>>
>> Error log:
>>
>>
>> /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.
39 matches
Mail list logo
