Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v5]

2025-04-05 Thread Kevin Rushforth
On Thu, 27 Mar 2025 15:21:09 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v3]

2025-04-05 Thread Martin Fox
On Mon, 24 Mar 2025 18:30:56 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v3]

2025-04-05 Thread Kevin Rushforth
On Thu, 3 Apr 2025 08:48:47 GMT, Ambarish Rapte wrote: >> Issue: >> The test execution fails when a relative path is specified a relative path >> for `TEST_SDK_PATH`. >> For example: >> 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test >> 2. gradle -PTEST_ONLY=true -PTEST_SDK_PA

Re: RFR: 8345348: CSS Media Queries [v2]

2025-04-05 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - revert - remove SceneMediaQueryContext - ad

RFR: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor

2025-04-05 Thread Jose Pereda
This PR fixes an issue when dragEvents occur in a secondary screen which doesn't have the same height or (macOS) origin as the main screen. The calculations for `xAbs, yAbs` are defined from the main screen macOS absolute origin, an in order to flip the coordinates defined from the JavaFX origi

Re: Resizing stage while it is maximized breaks scene size on Linux

2025-04-05 Thread Thiago Milczarek Sayão
The documentation states: "If this Window is an instance of Stage, changing this attribute will not visually affect the Window while fullScreen is true, but will be honored by the Window once fullScreen becomes false." Maybe it should also be the case for maximized state. Em sáb., 29 de mar. d

Re: Feature Request: Support for Transparent Title Bars in JavaFX Stages

2025-04-05 Thread Christopher Schnick
I just want to add that the native window handles are available prior to the windows being shown if you listen to the observable list Window.getWindows(). On 02/04/2025 16:01, Bahaa Zaid wrote: Hello, Modern macOS apps tend to expand the client area of the window to take the entire window ar

Re: RFR: 8313424: JavaFX controls in the title bar [v59]

2025-04-05 Thread Andy Goryachev
On Sun, 23 Mar 2025 09:21:06 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8351047: TitledPane should handle titles that are resizable

2025-04-05 Thread John Hendrikx
On Tue, 25 Mar 2025 17:08:02 GMT, Andy Goryachev wrote: >> This PR will forward more Label calculations to LabeledSkinBase, as they are >> quite complex, especially when a Graphic is involved which is a full-fledged >> `Node`. More specifically, this solves issues with TitledPane when the >> g

Feature Request: Support for Transparent Title Bars in JavaFX Stages

2025-04-05 Thread Bahaa Zaid
Hello, Modern macOS apps tend to expand the client area of the window to take the entire window area including the titlebar. This is usually done by: Setting NSWindow.titlebarAppearsTransparent to true. Setting NSWindow.styleMask NSWindowStyleMaskFullSizeContentView flag. This can be useful beca

Linux bug squashing

2025-04-05 Thread Thiago Milczarek Sayão
Hi, I'm doing some bug squashing work here: https://github.com/openjdk/jfx-sandbox/tree/glass_gtk_bug_squashing It's in the "it's worse now, but will be better later" phase :) The goal is to: - Honor the documentation on Stage class (it has statements on how iconify/maximize/fullscreen mix toge

[jfx24u] Integrated: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-05 Thread Jay Bhaskar
On Mon, 24 Mar 2025 12:52:42 GMT, Jay Bhaskar wrote: > A clean backport to jfx24u , the patch fixes current canvas pattern issue > where canvas pattern drawing was not working when using svg matrix image. This pull request has now been integrated. Changeset: 1ea359be Author:Jay Bhaskar UR

Integrated: 8350149: VBox ignores bias of child controls when fillWidth is set to false

2025-04-05 Thread John Hendrikx
On Sat, 22 Feb 2025 15:57:28 GMT, John Hendrikx wrote: > Fixes the case where `VBox` will ignore the (horizontal) bias of a child when > its fill width property is set to `false`. This manifests itself with labels > that have their wrap text property set to `true`, and the container is not >

Re: RFR: 8353668: Rename internal c.s.javafx.text.TextLine class

2025-04-05 Thread Andy Goryachev
On Thu, 3 Apr 2025 19:39:35 GMT, Michael Strauß wrote: >> This minor change renames an internal `com.sun.javafx.text.TextLine` to >> `PrismTextLine`. >> This class implements `com.sun.javafx.scene.text.TextLine` interface, also >> internal, for the purpose of reducing confusion and avoiding FQC

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-04-05 Thread Andy Goryachev
On Fri, 28 Mar 2025 21:09:55 GMT, Kevin Rushforth wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of t

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-05 Thread Lukasz Kostyra
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v4]

2025-04-05 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request with a new target base due to a merge or a rebase. The incrementa

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v8]

2025-04-05 Thread Kevin Rushforth
On Fri, 28 Mar 2025 15:10:46 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v2]

2025-04-05 Thread Andy Goryachev
On Mon, 31 Mar 2025 16:01:39 GMT, Kevin Rushforth wrote: >> The intent is not to annotate each test, but rather to use this tool to >> debug the issues in an intermittently failing test. > > Hmm. That isn't what I thought we were doing. I thought the idea was to > annotate most (if not all all)

Integrated: 8352268: RichEditorDemo: Save file doesn't always save

2025-04-05 Thread Andy Goryachev
On Tue, 18 Mar 2025 20:43:10 GMT, Andy Goryachev wrote: > Fixes embarrassing bugs in Rich Editor Demo: > > - File -> Save not saving > - File -> Open not emphasizing .rich files This pull request has now been integrated. Changeset: 0eda4df2 Author:Andy Goryachev URL: https://git.op

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v5]

2025-04-05 Thread Andy Goryachev
> Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new annotation to all the tests. > > The log contains a base

Re: RFR: 8353617: Remove deprecated TransitionEvent constructor

2025-04-05 Thread Andy Goryachev
On Thu, 3 Apr 2025 08:47:51 GMT, Michael Strauß wrote: > Remove the deprecated `TransitionEvent(EventType, StyleableProperty, > Duration)` constructor. > > A single reviewer should be sufficient. it's a "virtual particle": briefly came into existence then disappeared, contributing to mass whe

Proposal: A new universal Image API independent of java.desktop

2025-04-05 Thread Glavo
Hi, In https://github.com/openjdk/jfx/pull/1593, I saw some discussion about splitting the java.desktop module. In this discussion, I think Johan's point of view[1] is the most representative: > I totally agree. It is a (maintenance) nightmare to make sure the whole > java.desktop module is avail

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v4]

2025-04-05 Thread Kevin Rushforth
On Tue, 1 Apr 2025 20:47:32 GMT, Andy Goryachev wrote: >> Yes, there are two main approaches we could take: >> >> Option 1: A utility that is available for developers to add to one or more >> specific tests in a branch in their personal fork when debugging failures in >> those tests. We would

Re: RFR: 8351047: TitledPane should handle titles that are resizable

2025-04-05 Thread Michael Strauß
On Sat, 22 Mar 2025 12:20:17 GMT, John Hendrikx wrote: > This PR will forward more Label calculations to LabeledSkinBase, as they are > quite complex, especially when a Graphic is involved which is a full-fledged > `Node`. More specifically, this solves issues with TitledPane when the > graphi

Withdrawn: 8353163: [XWayland] Disable SwingNodePlatformExitCrashTest on wayland

2025-04-05 Thread Jayathirth D V
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote: > SwingNodePlatformExitCrashTest hangs while running on wayland, we need to > skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 > is fixed. This pull request has been closed without being integrated. ---

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v2]

2025-04-05 Thread Ambarish Rapte
> Issue: > The test execution fails when a relative path is specified a relative path > for `TEST_SDK_PATH`. > For example: > 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test > 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~**/jfx1/build test > > Solution: > Convert the relative

Re: RFR: 8351047: TitledPane should handle titles that are resizable

2025-04-05 Thread Michael Strauß
On Wed, 26 Mar 2025 21:48:23 GMT, Andy Goryachev wrote: >> That was just for deriving the `hpos` and `vpos` fields, which are no longer >> needed, in case `pos` was `null`. The `null` check is now handled in >> `LabeledSkinBase`. >> >> Of course we could think of some kind of derive option (h

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths [v2]

2025-04-05 Thread Kevin Rushforth
On Wed, 2 Apr 2025 06:14:31 GMT, Ambarish Rapte wrote: >> Issue: >> The test execution fails when a relative path is specified a relative path >> for `TEST_SDK_PATH`. >> For example: >> 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test >> 2. gradle -PTEST_ONLY=true -PTEST_SDK_PA

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-04-05 Thread Sergey Nazarkin
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-05 Thread Kevin Rushforth
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v9]

2025-04-05 Thread Oliver Schmidtmer
> Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text field, > including the NUL terminator and the remaining chars.

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v3]

2025-04-05 Thread Kevin Rushforth
On Mon, 24 Mar 2025 18:30:56 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-04-05 Thread Ziad El Midaoui
> Added multi line prompt support for TextArea this will provide the ability to > have multiple lines in textArea as expected, > Also fixed tests to meet the new changes Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision: changed wild

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

2025-04-05 Thread Jay Bhaskar
On Sat, 5 Apr 2025 05:27:40 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v18]

2025-04-05 Thread Michael Strauß
On Mon, 10 Mar 2025 16:25:40 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line >> 41: >> >>> 39: * @since 25 >>> 40: */ >>> 41: public abstract class LayoutInfo { >> >> Any exceptions thrown by methods of this class? > > only `public a

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-05 Thread Michael Strauß
On Fri, 4 Apr 2025 14:42:20 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs no

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test

2025-04-05 Thread Michael Strauß
On Fri, 4 Apr 2025 18:31:33 GMT, Andy Goryachev wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: RFR: 8345348: CSS Media Queries [v7]

2025-04-05 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: small refactor - Changes: - all: https://git.openjdk.org/jfx