On Wed, 10 Jan 2024 18:53:02 GMT, Carl Döbbelin wrote:
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
This pull request has now been integrated.
Changeset: 872dbc8a
Author: Carl Döbbelin
Committer: Marius Hanl
URL:
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the P
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: migrates tests to junit 5
-
Changes:
- all:
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with two additional
commits since the last revision:
- JDK-8323543: refactors tests and adds accessible attribute test for treetable
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
&g
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
&g
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: add test and fix for another npe
-
Changes:
- all:
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: clean up code
-
Changes:
- all: https://git.openj
This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
items were null.
-
Commit messages:
- JDK-8323543: adds similar safety test in TreeTableViewTest
- JDK-8323543: Fixes Nullpointer in TableSkinUtils
Changes: https://git.openjdk.org/jfx/pull/1329/files
Webr
On Sat, 13 May 2023 15:56:15 GMT, Carl Döbbelin wrote:
> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
This pull request has now been integrated.
Changeset: e7974bc8
Author: Carl Döbbelin
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/
On Sat, 13 May 2023 17:23:55 GMT, Carl Döbbelin wrote:
>> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refactored HostUt
> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
removed HostUtils
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1134/files
-
> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
refactored HostUtils
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1134/fi
On Sat, 13 May 2023 16:40:39 GMT, Carl Döbbelin wrote:
>> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added isEmbed
On Sat, 13 May 2023 16:48:12 GMT, Nir Lisker wrote:
>> modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/HostUtils.java
>> line 60:
>>
>>> 58:
>>> 59: public static boolean isWindows() {
>>> 60: return osName.startsWith("windows");
>>
>> `osName` is unused now
>
> `osA
> replaced implementation of OS checks in HostUtils with calls of PlatformUtil
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
added isEmbedded
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1134/files
-
replaced implementation of OS checks in HostUtils with calls of PlatformUtil
-
Commit messages:
- replaced implementation of OS checks in HostUtils with calls of PlatformUtil
Changes: https://git.openjdk.org/jfx/pull/1134/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1134&
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote:
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
This pull request has now been integrated.
Changeset: 70953643
Author: Carl Döbbelin
C
On Fri, 12 May 2023 15:09:35 GMT, Kevin Rushforth wrote:
> > Looks good. Do you want to replace `HostUtils`'s OS detection with
> > `PlatformUtil` (or were they split on purpose)?
>
> I think this might be a good change, but I'll leave it up to @EstelonAgarwaen
> . To minimize the intrusion, y
On Fri, 12 May 2023 15:24:27 GMT, Andy Goryachev wrote:
>> Darwin OS was a precursor of OS X that followed after rhapsody. As its own
>> OS it stopped being supported in 2002. since kevin was discussing to only
>> support MacOS 11 or newer in jfx 21, i think its safe to say we dont support
>>
On Fri, 12 May 2023 15:15:09 GMT, Andy Goryachev wrote:
>> I initially had the same thought. What this actually highlights, though, is
>> the danger of having this sort of check scattered in multiple places, but
>> done differently. If it was important that "darwin" be recognized (it
>> isn't)
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
made launcherimpl one line
--
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
Delete jarRepositories.xml
--
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
removed unneeded idea xml and imp
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
added export of javafx.base to java
On Thu, 11 May 2023 16:20:10 GMT, Kevin Rushforth wrote:
> > > > I cannot use the PlatformUtils in the
> > > > `com.sun.webkit.network.URLLoader` class, as the PlatformUtils are not
> > > > Exported to the corresponding module.
> > >
> > >
> > > I wonder if this was done on purpose.
> >
> >
On Thu, 11 May 2023 15:43:30 GMT, Nir Lisker wrote:
> > I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader`
> > class, as the PlatformUtils are not Exported to the corresponding module.
>
> I wonder if this was done on purpose.
i assumed it was.
-
PR Comment:
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote:
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader` class,
as the Platf
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
Carl Döbbelin has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-8307807-repla
Replaced querying of `System.getProperty("os.name")` to check for OS with the
use of the methods provided by `PlatformUtils`
-
Commit messages:
- Merge branch 'master' into
JDK-8307807-replace-system-getproperty-osname-platform-utils
- replaced sensible spots of system getproperty
33 matches
Mail list logo
