Re: RFR: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Johan Vos
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. Thanks for this. @tiainen can you review?

headless platform in sandbox

2024-09-20 Thread Johan Vos
Hi, Here is a quick update about the headless platform support, as developed in the jfx-sandbox repo [1]. While there is a Robot implementation in the headless platform (com.sun.glass.ui.headless), there are still many test failures because we don't read the pixels (yet). When running the systemte

Re: RFR: 8340405: JavaFX shutdown hook can hang preventing app from exiting

2024-09-20 Thread Johan Vos
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote: > This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs > when called from the QuantumToolkit shutdown hook. A shutdown hook should > never run indefinitely, so the fix is to call dispose from a background > threa

Re: RFR: 8340405: JavaFX shutdown hook can hang preventing app from exiting

2024-09-19 Thread Johan Vos
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote: > This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs > when called from the QuantumToolkit shutdown hook. A shutdown hook should > never run indefinitely, so the fix is to call dispose from a background > threa

Re: [jfx23] RFR: 8339247: Create release notes for JavaFX 23

2024-09-12 Thread Johan Vos
On Thu, 12 Sep 2024 11:43:14 GMT, Kevin Rushforth wrote: > Backport the JavaFX 23 release notes to the `jfx23` branch. Note that we will > _not_ trigger a respin of JavaFX 23 as a result of this. Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/

[jfx17u] Integrated: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 12:19:40 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 33d82c04 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and > was reviewed by Kevin Rushfort

[jfx21u] Integrated: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 12:23:42 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 33d82c04 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and > was reviewed by Kevin Rushfort

[jfx21u] RFR: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit 33d82c04 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and was reviewed by Kevin Rushforth. Thanks! - Commit messages: - Backport 33d82c04dd8c4c3fa9188da5c263e0f406a

[jfx17u] RFR: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit 33d82c04 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and was reviewed by Kevin Rushforth. Thanks! - Commit messages: - Backport 33d82c04dd8c4c3fa9188da5c263e0f406a

[jfx17u] Integrated: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 10:06:27 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 34bbf853 from the openjdk/jfx > repository. > > The commit being backported was authored by Hima Bindu Meda on 16 Jul 2024 > and was reviewed by Kevin Rushf

[jfx21u] Integrated: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 09:57:50 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit > [34bbf853](https://github.com/openjdk/jfx/commit/34bbf85362fae946c6306eb52a8478aa2ca3ef5f) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. >

[jfx17u] RFR: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit 34bbf853 from the openjdk/jfx repository. The commit being backported was authored by Hima Bindu Meda on 16 Jul 2024 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport 34bbf85362fae9

[jfx21u] RFR: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit [34bbf853](https://github.com/openjdk/jfx/commit/34bbf85362fae946c6306eb52a8478aa2ca3ef5f) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Hima Bindu Meda on 16 Jul 2024 and was

Re: [jfx17u] RFR: 8318984: Update to Xcode 14.3.1 on macOS

2024-09-11 Thread Johan Vos
On Tue, 10 Sep 2024 13:39:11 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [d24e96a6](https://github.com/openjdk/jfx/commit/d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

Re: [jfx17u] RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-10 Thread Johan Vos
On Tue, 10 Sep 2024 12:36:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

Re: [jfx23u] RFR: 8339848: Change JavaFX release version to 23.0.2 in jfx23u

2024-09-10 Thread Johan Vos
On Tue, 10 Sep 2024 15:01:03 GMT, Kevin Rushforth wrote: > Bump version number to 23.0.2 Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx23u/pull/20#pullrequestreview-2293139860

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX

2024-09-08 Thread Johan Vos
On Fri, 6 Sep 2024 22:43:11 GMT, Kevin Rushforth wrote: > > Old version of classes `netscape.javascript.JSObject` and > > `netscape.javascript.JSException` seems to be delivered with JavaFX for > > Android [1]. > > Should these classes be removed? > > [1] : > > https://github.com/openjdk/jfx/t

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX [v2]

2024-09-08 Thread Johan Vos
On Fri, 6 Sep 2024 22:56:37 GMT, Kevin Rushforth wrote: >> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered >> by the JDK, but will be terminally-deprecated in JDK 24 by >> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for >> review at ope

Re: RFR: 8337280: Include jdk.jsobject module with JavaFX

2024-09-06 Thread Johan Vos
Hi Kevin, Thanks for the extensive checks on these scenario's. I believe the scenario where jlink is used with an "old" JDK (e.g. 21) in combination with the most recent JavaFX release is very common. In that case, it seems to be required to prepend the module path with $JAVA_HOME/jmods, correct?

Integrated: 8339335: set number of parallel jobs when building webkit

2024-09-04 Thread Johan Vos
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. >

Re: RFR: 8339335: set number of parallel jobs when building webkit [v2]

2024-09-03 Thread Johan Vos
build.gradle` to the > `build-webkit` script. When not setting `NUM_COMPILE_THREADS` explicitly,it > will default to the number of CPU's as well, hence it will have the same > behavior as without this PR. > When setting `NUM_COMPILE_THREADS` explicitly, the provided number will be &g

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Tue, 3 Sep 2024 17:46:17 GMT, Kevin Rushforth wrote: > Btw, I ran another CI build with the `NUM_COMPILE_THREADS=1` workaround for > Mac removed, and the build times are good again. In fact, the x64 build runs > even faster than before -- possibly because WebKit build defaults to a lower >

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Tue, 3 Sep 2024 17:27:15 GMT, Kevin Rushforth wrote: > Presuming that my testing shows no problems, I propose the following: > > 1. I will close [JDK-8089417](https://bugs.openjdk.org/browse/JDK-8089417) as > "Cannot reproduce" > 2. I will file a new bug to remove the workaround that current

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. >

Re: RFR: 8339335: set number of parallel jobs when building webkit

2024-09-03 Thread Johan Vos
On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos wrote: > When building webkit, the perl script in > `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check > for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to > `numberOfCPUs()`. >

Re: parallel threads when building webkit

2024-09-03 Thread Johan Vos
ore it succeeds (on Linux). > And I used an old Ryzen 7 1700X with 16 threads, 16GB. I have now upgraded > it, but I haven't built webkit yet. I'm really scared of it :) > > So limiting the threads seems like a good idea. > > > Em qua., 24 de abr. de 2024 às 04:

RFR: 8339335: set number of parallel jobs when building webkit

2024-09-02 Thread Johan Vos
When building webkit, the perl script in `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to `numberOfCPUs()`. This PR passes the `NUM_COMPILE_THREADS` from `build.gradle` to the `build-webkit`

Re: RFR: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

2024-08-29 Thread Johan Vos
On Thu, 29 Aug 2024 11:49:58 GMT, Jose Pereda wrote: > This PR adds the required annotations to the iOS sources in the JavaFX Web > module, to allow the compilation of such sources, now that `-Werror` is > enabled, in the same way that was done for > https://bugs.openjdk.java.net/browse/JDK-82

[jfx23u] Integrated: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:46:00 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 25ac6fed from the openjdk/jfx > repository. > > The commit being backported was authored by Johan Vos on 25 Jul 2024 and was > reviewed by John Hendrikx, Am

[jfx23u] Integrated: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:36:48 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit > [1bdb93c7](https://github.com/openjdk/jfx/commit/1bdb93c792cf7c218c74ec5cacda8bac1242f73b) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. >

[jfx17u] Integrated: 8334657: Enable binary check

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:37:23 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 101e5175 from the openjdk/jfx > repository. > > The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 > and was reviewed by Ambaris

[jfx21u] Integrated: 8334657: Enable binary check

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:46:48 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 101e5175 from the openjdk/jfx > repository. > > The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 > and was reviewed by Ambaris

[jfx21u] RFR: 8334657: Enable binary check

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit 101e5175 from the openjdk/jfx repository. The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 and was reviewed by Ambarish Rapte and Phil Race. Thanks! - Commit messages: - Backport 101e5175ff429828de

[jfx23u] RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit 25ac6fed from the openjdk/jfx repository. The commit being backported was authored by Johan Vos on 25 Jul 2024 and was reviewed by John Hendrikx, Ambarish Rapte and Jose Pereda. Thanks! - Commit messages: - Backport

[jfx17u] RFR: 8334657: Enable binary check

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit 101e5175 from the openjdk/jfx repository. The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 and was reviewed by Ambarish Rapte and Phil Race. Thanks! - Commit messages: - Backport 101e5175ff429828de

[jfx23u] RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-08-18 Thread Johan Vos
Hi all, This pull request contains a backport of commit [1bdb93c7](https://github.com/openjdk/jfx/commit/1bdb93c792cf7c218c74ec5cacda8bac1242f73b) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Jose Pereda on 25 Jul 2024 and was revi

Re: Update on the headless platform (sandbox)

2024-08-08 Thread Johan Vos
> Is there any progress update on this? It appears (I may be wrong) to be a > low risk addition to JavaFX, but with significant benefits, particularly as > Monocle is no longer part of JavaFX builds. > > Thanks, > Craig > > On Thu, Apr 25, 2024 at 12:49 PM Johan Vos wrote:

[jfx17u] Integrated: 8329011: Update SQLite to 3.45.3

2024-08-02 Thread Johan Vos
On Fri, 2 Aug 2024 13:08:26 GMT, Johan Vos wrote: > 8329011: Update SQLite to 3.45.3 This pull request has now been integrated. Changeset: eb330d88 Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/eb330d883d32b9cc1f9d0c894b01b160b2bfe2c3 Stats: 26451 lines in 4 fi

[jfx21u] Integrated: 8329011: Update SQLite to 3.45.3

2024-08-02 Thread Johan Vos
On Fri, 2 Aug 2024 13:04:30 GMT, Johan Vos wrote: > 8329011: Update SQLite to 3.45.3 This pull request has now been integrated. Changeset: 454ac50c Author: Johan Vos URL: https://git.openjdk.org/jfx21u/commit/454ac50cea8f93f5c8bd7c30393d0ca2648b245f Stats: 26451 lines in 4 fi

[jfx17u] RFR: 8329011: Update SQLite to 3.45.3

2024-08-02 Thread Johan Vos
8329011: Update SQLite to 3.45.3 - Commit messages: - Backport 581e3a70a45a550a97e391e06735f4837336ada8 Changes: https://git.openjdk.org/jfx17u/pull/197/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=197&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329011 St

[jfx21u] RFR: 8329011: Update SQLite to 3.45.3

2024-08-02 Thread Johan Vos
8329011: Update SQLite to 3.45.3 - Commit messages: - Backport 581e3a70a45a550a97e391e06735f4837336ada8 Changes: https://git.openjdk.org/jfx21u/pull/67/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=67&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8329011 Stat

[jfx21u] Integrated: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-01 Thread Johan Vos
On Thu, 1 Aug 2024 10:04:12 GMT, Johan Vos wrote: > almost clean backport of 8319779: SystemMenu: memory leak due to listener > never being removed > Didn't apply clean because the imports where shuffled. This pull request has now been integrated. Changeset: ef8397aa Author:

[jfx21u] Integrated: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-08-01 Thread Johan Vos
On Thu, 1 Aug 2024 08:47:38 GMT, Johan Vos wrote: > Almost clean backport of JDK-8334874: Horizontal scroll events from touch > pads should scroll the TabPane tabs > The only change was the (c) date that had changed. This pull request has now been integrated. Changeset: 29aa85

[jfx21u] RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-01 Thread Johan Vos
almost clean backport of 8319779: SystemMenu: memory leak due to listener never being removed Didn't apply clean because the imports where shuffled. - Commit messages: - Backport 25ac6fed22d0f49d01c831aaa48049c34899fe96 Changes: https://git.openjdk.org/jfx21u/pull/66/files Webrev

[jfx21u] Withdrawn: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-01 Thread Johan Vos
On Thu, 1 Aug 2024 08:41:59 GMT, Johan Vos wrote: > Backport of 8323787: Mac System MenuBar throws IOB exception > > Required manual changes as the location of the test has changed. This pull request has been closed without being integrated. - PR: https://git.openjdk.o

Re: [jfx21u] RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-01 Thread Johan Vos
On Thu, 1 Aug 2024 08:41:59 GMT, Johan Vos wrote: > Backport of 8323787: Mac System MenuBar throws IOB exception > > Required manual changes as the location of the test has changed. closed in favor of #66 - PR Comment: https://git.openjdk.org/jfx21u/pull/63#iss

[jfx21u] Integrated: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used

2024-08-01 Thread Johan Vos
On Thu, 1 Aug 2024 09:23:42 GMT, Johan Vos wrote: > 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is > used This pull request has now been integrated. Changeset: e6f725f5 Author: Johan Vos URL: https://git.openjdk.org/jfx21u/

[jfx21u] RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used

2024-08-01 Thread Johan Vos
8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used - Commit messages: - Backport 8dd3c37cae3dd52dc3a258033d0e8f168ceaf307 Changes: https://git.openjdk.org/jfx21u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=65&range=00 Issue:

[jfx21u] RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-08-01 Thread Johan Vos
Almost clean backport of JDK-8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs The only change was the (c) date that had changed. - Commit messages: - 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs Changes: https://g

[jfx21u] RFR: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-01 Thread Johan Vos
Backport of 8323787: Mac System MenuBar throws IOB exception Required manual changes as the location of the test has changed. - Commit messages: - 8319779: SystemMenu: memory leak due to listener never being removed Changes: https://git.openjdk.org/jfx21u/pull/63/files Webrev: h

Re: RFR: 8337281: build.gradle assumes all modules are named "javafx.$project" [v2]

2024-07-30 Thread Johan Vos
On Fri, 26 Jul 2024 23:00:33 GMT, Kevin Rushforth wrote: >> This PR fixes a bad assumption in a few places in `build.gradle`, which >> assumes that the module name can be derived from the name of the gradle >> project name by prepending `"javafx."` to the name rather than using the >> `moduleN

Integrated: 8319779: SystemMenu: memory leak due to listener never being removed

2024-07-25 Thread Johan Vos
On Fri, 10 Nov 2023 10:34:08 GMT, Johan Vos wrote: > A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 This pull request has now been integrated. Changeset: 25ac6f

[jfx21u] Integrated: 8336733: Change JavaFX release version to 21.0.5 in jfx21u

2024-07-18 Thread Johan Vos
On Thu, 18 Jul 2024 08:34:10 GMT, Johan Vos wrote: > Start work on 21.0.5 This pull request has now been integrated. Changeset: c1ddcf8b Author: Johan Vos URL: https://git.openjdk.org/jfx21u/commit/c1ddcf8ba5ae3c81366ad7935e45450177b9ba9d Stats: 2 lines in 2 files changed: 0

Re: [jfx17u] RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2024-07-18 Thread Johan Vos
On Tue, 2 Jul 2024 08:21:54 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [a118d333](https://github.com/openjdk/jfx/commit/a118d33314a363336134d31c45b50329594e5a24) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit

[jfx17u] Integrated: 8336730: Change JavaFX release version to 17.0.13 in jfx17u

2024-07-18 Thread Johan Vos
On Thu, 18 Jul 2024 08:31:42 GMT, Johan Vos wrote: > Start work on 17.0.13 This pull request has now been integrated. Changeset: e2b18b1d Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/e2b18b1d30074406cca1541c195d8cb369d18935 Stats: 2 lines in 2 files changed

Re: [jfx23u] Integrated: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2024-07-18 Thread Johan Vos
On Fri, 12 Jul 2024 14:41:27 GMT, Kevin Rushforth wrote: > This is a copy of the jfx22u README and CONTRIBUTING docs, changing 22 to 23, > with one additional change to add the word "Updates" after "23" in one place > where it was missing (the current wording could mislead developers into > th

[jfx21u] RFR: 8336733: Change JavaFX release version to 21.0.5 in jfx21u

2024-07-18 Thread Johan Vos
Start work on 21.0.5 - Commit messages: - Start work on 21.0.5 Changes: https://git.openjdk.org/jfx21u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336733 Stats: 2 lines in 2 files changed: 0 ins; 0 d

Re: [jfx21u] RFR: 8336733: Change JavaFX release version to 21.0.5 in jfx21u

2024-07-18 Thread Johan Vos
On Thu, 18 Jul 2024 08:34:10 GMT, Johan Vos wrote: > Start work on 21.0.5 start work on 21.0.5 - PR Comment: https://git.openjdk.org/jfx21u/pull/62#issuecomment-2235947269

[jfx17u] RFR: 8336730: Change JavaFX release version to 17.0.13 in jfx17u

2024-07-18 Thread Johan Vos
Start work on 17.0.13 - Commit messages: - Start work on 17.0.13 Changes: https://git.openjdk.org/jfx17u/pull/196/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=196&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336730 Stats: 2 lines in 2 files changed: 0 ins;

Re: [jfx23u] RFR: 8336035: Change JavaFX release version to 23.0.1 in jfx23u

2024-07-18 Thread Johan Vos
On Thu, 11 Jul 2024 22:56:18 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 23.0.1 release. Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx23u/pull/1#pullrequestreview-2184887758

Re: [jfx22u] RFR: Merge b2c7b485d9ebf3c773693c4310f31d90aec6f7d6

2024-07-16 Thread Johan Vos
On Tue, 16 Jul 2024 11:18:34 GMT, Kevin Rushforth wrote: > Clean merge of July CPU content into `jfx22u:master`. Note that this is a > no-op merge, since there is no security content for this release. The only > content is some identity merge commits. There are no changes to the contents > of

Re: [jfx22u] RFR: 8336327: Create release notes for JavaFX 22.0.2

2024-07-16 Thread Johan Vos
On Fri, 12 Jul 2024 18:44:15 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 22.0.2. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=45846 > > The original filter, with the backport IDs, is here: > > https://bugs.

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-07-14 Thread Johan Vos
On Tue, 9 Jul 2024 14:50:08 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java >> line 321: >> >>> 319: Stage stage = new Stage(); >>> 320: stage.setScene(new Scene(root)); >>> 321: stage.show(); >>

Re: consistent naming for tests

2024-07-10 Thread Johan Vos
Thanks all for commenting. What I have read so far seems that there is an agreement for this approach: * don't prefix tests with `test` anymore * use a (somehow) descriptive name * add a comment that refers to the JBS issue that this test is dealing with * (optional) in case the test or test scenar

consistent naming for tests

2024-07-09 Thread Johan Vos
Hi, An interesting question from John Hendrikx ( https://github.com/openjdk/jfx/pull/1283/#discussion_r1637684395) probably needs some general discussion on this list. Afaik, we don't have guidelines for how to name tests (in https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#coding-style-

Re: RFR: 8335934: Change JavaFX release version to 24

2024-07-09 Thread Johan Vos
On Mon, 8 Jul 2024 22:51:47 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 24. I will integrate this to `master` as > part of forking the `jfx23` stabilization branch, which is scheduled for > Thursday, July 11, 2024 at 16:00 UTC. Marked as reviewed by jvos (Reviewer). ---

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-07-09 Thread Johan Vos
On Wed, 19 Jun 2024 14:25:52 GMT, Ambarish Rapte wrote: >> Johan Vos has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - process more reviewer comments >> - Process reviewer comments > > tests/system/

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-07-09 Thread Johan Vos
On Wed, 19 Jun 2024 12:39:11 GMT, Ambarish Rapte wrote: >> Johan Vos has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - process more reviewer comments >> - Process reviewer comments > > tests/system/

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-07-09 Thread Johan Vos
On Thu, 13 Jun 2024 07:17:01 GMT, John Hendrikx wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add more type info > > tests/system/src/test/java/test/com/sun/javafx/tk/quantum/Syst

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v21]

2024-07-09 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Allow

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v20]

2024-07-09 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with three additional commits since the last revision: - Ad

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v19]

2024-07-08 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now co

Re: RFR: 8326712: Robot tests fail on XWayland

2024-06-28 Thread Johan Vos
On Fri, 28 Jun 2024 07:49:26 GMT, Alexander Zvegintsev wrote: >> Most of the headful test failures on XWayland are due to screen capture is >> not working. >> >> Wayland, unlike X11, does not allow arbitrary applications to capture the >> screen contents directly. >> Instead, screen capture f

Re: RFR: 8326712: Robot tests fail on XWayland

2024-06-28 Thread Johan Vos
On Thu, 27 Jun 2024 18:26:20 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/fp_pipewire.h line 26: >> >>> 24: */ >>> 25: >>> 26: #ifdef HEADLESS >> >> There is no HEADLESS build for JavaFX. I see the same ifdef in other C >> files in this PR. >> I guess its

[jfx21u] Integrated: 8329705: Add missing Application thread checks to platform specific a11y methods

2024-06-25 Thread Johan Vos
On Mon, 24 Jun 2024 17:23:30 GMT, Johan Vos wrote: > 8329705: Add missing Application thread checks to platform specific a11y > methods This pull request has now been integrated. Changeset: b90f009d Author: Johan Vos URL: https://git.openjdk.org/jfx21u/

[jfx17u] Integrated: 8329705: Add missing Application thread checks to platform specific a11y methods

2024-06-25 Thread Johan Vos
On Mon, 24 Jun 2024 17:23:53 GMT, Johan Vos wrote: > 8329705: Add missing Application thread checks to platform specific a11y > methods This pull request has now been integrated. Changeset: a205815f Author: Johan Vos URL: https://git.openjdk.org/jfx17u/

[jfx21u] RFR: 8329705: Add missing Application thread checks to platform specific a11y methods

2024-06-24 Thread Johan Vos
8329705: Add missing Application thread checks to platform specific a11y methods - Commit messages: - Backport 0eb4d7196099d817cc6467985b882242845bdd2e Changes: https://git.openjdk.org/jfx21u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=61&range=00 Issue: ht

[jfx17u] RFR: 8329705: Add missing Application thread checks to platform specific a11y methods

2024-06-24 Thread Johan Vos
8329705: Add missing Application thread checks to platform specific a11y methods - Commit messages: - Backport 0eb4d7196099d817cc6467985b882242845bdd2e Changes: https://git.openjdk.org/jfx17u/pull/194/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=194&range=00 Issue:

[jfx17u] Integrated: 8301312: Create implementation of NSAccessibilityButton protocol

2024-06-24 Thread Johan Vos
On Mon, 24 Jun 2024 13:47:54 GMT, Johan Vos wrote: > 8301312: Create implementation of NSAccessibilityButton protocol This pull request has now been integrated. Changeset: cf66048e Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/cf66048eb7519a2c652ccf388218c385e8820

[jfx17u] RFR: 8301312: Create implementation of NSAccessibilityButton protocol

2024-06-24 Thread Johan Vos
8301312: Create implementation of NSAccessibilityButton protocol - Commit messages: - Backport 05548ace27f099a5ce152e3fb9efb4d22da683c8 Changes: https://git.openjdk.org/jfx17u/pull/193/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=193&range=00 Issue: https://bugs.ope

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-06-13 Thread Johan Vos
On Thu, 13 Jun 2024 10:25:15 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add more type info > > modules/javafx.graphics/src/shims/java/com/sun/javafx/tk/quantum/Gl

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2024-06-13 Thread Johan Vos
On Tue, 12 Dec 2023 07:05:49 GMT, Ambarish Rapte wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > Looks all good to me. > Is it possible to add an auto

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-06-13 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with two additional commits since the last revision: - pro

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v17]

2024-06-13 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now co

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2024-06-12 Thread Johan Vos
On Wed, 13 Dec 2023 09:20:12 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > About adding an automated test, the leak t

Re: JavaFX on Windows ARM

2024-06-09 Thread Johan Vos
Hi Christopher, The question about Windows. AArch64 increasingly pops up. We did some local tests, and the basis modules builds out-of-the-box, but media and web modules require more work. It's definitely helpful that there are GA runners for it now -- although the GA is just a basic check. It wou

[jfx21u] Integrated: 8332539: Update libxml2 to 2.12.7

2024-06-04 Thread Johan Vos
On Tue, 4 Jun 2024 17:39:04 GMT, Johan Vos wrote: > 8332539: Update libxml2 to 2.12.7 This pull request has now been integrated. Changeset: 1d2bc14d Author: Johan Vos URL: https://git.openjdk.org/jfx21u/commit/1d2bc14df14d09a921194b273249e394fb1012ff Stats: 67 lines in 9 fi

[jfx17u] Integrated: 8332539: Update libxml2 to 2.12.7

2024-06-04 Thread Johan Vos
On Tue, 4 Jun 2024 17:39:07 GMT, Johan Vos wrote: > 8332539: Update libxml2 to 2.12.7 This pull request has now been integrated. Changeset: 14575c54 Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/14575c54a2b665384bbf4d81a1e2672912691562 Stats: 67 lines in 9 fi

[jfx21u] RFR: 8332539: Update libxml2 to 2.12.7

2024-06-04 Thread Johan Vos
8332539: Update libxml2 to 2.12.7 - Commit messages: - Backport dedcf1d236b5429dcf3c42f5fd1095b28d5da063 Changes: https://git.openjdk.org/jfx21u/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332539 Sta

[jfx17u] RFR: 8332539: Update libxml2 to 2.12.7

2024-06-04 Thread Johan Vos
8332539: Update libxml2 to 2.12.7 - Commit messages: - Backport dedcf1d236b5429dcf3c42f5fd1095b28d5da063 Changes: https://git.openjdk.org/jfx17u/pull/192/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=192&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332539 S

[jfx17u] Integrated: 8331748: Update libxml2 to 2.12.6

2024-06-04 Thread Johan Vos
On Tue, 4 Jun 2024 14:18:04 GMT, Johan Vos wrote: > 8331748: Update libxml2 to 2.12.6 This pull request has now been integrated. Changeset: 1dfcbed2 Author: Johan Vos URL: https://git.openjdk.org/jfx17u/commit/1dfcbed2f5586c3efceed4c95ebec3d23ee99573 Stats: 24912 lines in

[jfx21u] Integrated: 8331748: Update libxml2 to 2.12.6

2024-06-04 Thread Johan Vos
On Tue, 4 Jun 2024 14:19:52 GMT, Johan Vos wrote: > 8331748: Update libxml2 to 2.12.6 This pull request has now been integrated. Changeset: f8e75ca6 Author: Johan Vos URL: https://git.openjdk.org/jfx21u/commit/f8e75ca6b9fc2005285f76fe958c589cb9a328c3 Stats: 24912 lines in

[jfx17u] Integrated: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-06-04 Thread Johan Vos
On Tue, 4 Jun 2024 14:36:16 GMT, Johan Vos wrote: > 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 This pull request has now been integrated. Changeset: 3a7cad84 Author: Johan Vos URL: https://git.openjdk.org/jfx17u/com

[jfx21u] Integrated: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-06-04 Thread Johan Vos
On Tue, 4 Jun 2024 14:35:28 GMT, Johan Vos wrote: > 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 This pull request has now been integrated. Changeset: 20866584 Author: Johan Vos URL: https://git.openjdk.org/jfx21u/com

[jfx17u] RFR: 8331748: Update libxml2 to 2.12.6

2024-06-04 Thread Johan Vos
8331748: Update libxml2 to 2.12.6 - Commit messages: - Backport 97b1402501983f121f75c24a510f466837fa2ecc Changes: https://git.openjdk.org/jfx17u/pull/190/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=190&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331748 S

[jfx17u] RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-06-04 Thread Johan Vos
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 - Commit messages: - Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88 Changes: https://git.openjdk.org/jfx17u/pull/191/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=191&range=00 Issue: https:/

[jfx21u] RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-06-04 Thread Johan Vos
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 - Commit messages: - Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88 Changes: https://git.openjdk.org/jfx21u/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=59&range=00 Issue: https://b

[jfx21u] RFR: 8331748: Update libxml2 to 2.12.6

2024-06-04 Thread Johan Vos
8331748: Update libxml2 to 2.12.6 - Commit messages: - Backport 97b1402501983f121f75c24a510f466837fa2ecc Changes: https://git.openjdk.org/jfx21u/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=58&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331748 Sta

Re: JavaFX applications fail to build with Maven 3.9.7

2024-05-29 Thread Johan Vos
Yes, that is why I filed https://bugs.openjdk.org/browse/JDK-8333147 (which hints at a fix: Instead of `classifier "$t.name"` we should now use `archiveClassifier.set( t.name)` ) - Johan On Wed, May 29, 2024 at 4:58 PM John Neffenger wrote: > On 5/29/24 12:19 AM, Joeri Sykora wrote: > > maven a

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v9]

2024-05-24 Thread Johan Vos
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

  1   2   3   4   5   6   7   >