Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak)

2024-10-03 Thread Thiago Milczarek Sayao
On Tue, 1 Oct 2024 17:37:15 GMT, Thiago Milczarek Sayao wrote: > When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When > scene changes, this is called on `WindowStage.java`: > > `QuantumRenderer.getInstance().disposePresentable(painter.presentable); // >

Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak)

2024-10-03 Thread Thiago Milczarek Sayao
On Tue, 1 Oct 2024 17:37:15 GMT, Thiago Milczarek Sayao wrote: > When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When > scene changes, this is called on `WindowStage.java`: > > `QuantumRenderer.getInstance().disposePresentable(painter.presentable); // >

RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak)

2024-10-03 Thread Thiago Milczarek Sayao
When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When scene changes, this is called on `WindowStage.java`: `QuantumRenderer.getInstance().disposePresentable(painter.presentable); // latched on RT` But the underlying `DrawableInfo` is never freed. I also think this should b

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-10-03 Thread Thiago Milczarek Sayao
On Wed, 21 Aug 2024 09:58:53 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v26]

2024-10-03 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 105 commits: - Remove idea file - Fix the case when IME filters

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-10-03 Thread Thiago Milczarek Sayao
On Wed, 2 Oct 2024 09:06:17 GMT, Lukasz Kostyra wrote: > I have an issue in IMETest with the new patch. This does not happen on > master, so I suspect it's a regression. > > I tried typing with polish keyboard and it seems like it does not pick up the > special characters which use diacritical

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-10-02 Thread Thiago Milczarek Sayao
On Wed, 21 Aug 2024 09:58:53 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v17]

2024-10-02 Thread Thiago Milczarek Sayao
On Sun, 25 Aug 2024 20:59:43 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-09-26 Thread Thiago Milczarek Sayao
On Wed, 21 Aug 2024 09:58:53 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-09-24 Thread Thiago Milczarek Sayao
On Wed, 21 Aug 2024 09:58:53 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v17]

2024-08-25 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v16]

2024-08-25 Thread Thiago Milczarek Sayao
On Sun, 25 Aug 2024 20:00:44 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v16]

2024-08-25 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Withdrawn: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-25 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is map

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-25 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. T

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-21 Thread Thiago Milczarek Sayao
On Mon, 19 Aug 2024 17:39:38 GMT, Martin Fox wrote: >> on mac and windows the coordinates can be negative, depending on the screen >> arrangement. >> >> why do we need to rely on the fact that `pos[]` values are positive anyway? > > I was able to set up a multiple monitor system. Linux does wor

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-08-21 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Remove negative checks - Changes: - all: https://git.openjdk.org/jfx/p

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-19 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped.

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 20:28:20 GMT, Kevin Rushforth wrote: > This causes a regression on Ubuntu 22.04. The following tests fail with this > fix (they all pass with current master), when using X.org or Wayland: > > ``` > SizeToSceneTest > testInitialSizeOnFullscreenThenSizeToScene() FAILED > o

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-18 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. T

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v24]

2024-08-18 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision: - Revert idea file - Remove unused import - Changes: - all: https://

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 15:48:00 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v23]

2024-08-18 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 98 commits: - Fix review points - Merge branch 'master' i

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 15:54:30 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-18 Thread Thiago Milczarek Sayao
On Fri, 16 Aug 2024 15:41:44 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 96 commits: >> >> - Merge branch 'refs/heads/master' into new_

Integrated: 8332222: Linux Debian: Maximized stage shrinks when opening another stage

2024-08-06 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 21:28:47 GMT, Thiago Milczarek Sayao wrote: > Specific to KDE, in the case of the example provided, when an MODAL window > pops, it calls `set_enabled` `false` on the child (or all other windows if > APPLICATION_MODAL) which causes it to update the window constrai

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-08-06 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v15]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:14:54 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-07-29 Thread Thiago Milczarek Sayao
On Ubuntu 24.04 with Xorg windows are not shown centered. This is due a configure event being received with position 0,0 which is wrong. The fix ignores the configure events until the window is mapped. - Commit messages: - 8337400: [Linux] Initial window position is not centered on

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v15]

2024-07-29 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 17 Jun 2024 23:34:06 GMT, Andy Goryachev wrote: > I've tested a bit more on linux mint (not a KDE desktop), see no ill effects. > > There were a couple of warnings opening modal and regular windows, but the > same warnings are present in the master branch. > > For completeness sake, he

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Thiago Milczarek Sayao
ply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision: - Revert idea file - Fix only the original bug -

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v4]

2024-07-29 Thread Thiago Milczarek Sayao
ply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in b

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v14]

2024-07-08 Thread Thiago Milczarek Sayao
On Sun, 9 Jun 2024 13:12:44 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v14]

2024-07-07 Thread Thiago Milczarek Sayao
On Sun, 9 Jun 2024 13:12:44 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8326712: Robot tests fail on XWayland

2024-06-28 Thread Thiago Milczarek Sayao
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev wrote: > Most of the headful test failures on XWayland are due to screen capture is > not working. > > Wayland, unlike X11, does not allow arbitrary applications to capture the > screen contents directly. > Instead, screen capture functio

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-06-17 Thread Thiago Milczarek Sayao
On Mon, 17 Jun 2024 18:54:15 GMT, Andy Goryachev wrote: > Initial comments: > > 1. the description says this fixes two issues. do we have two JBS tickets? > if so, please add the other ticket to this PR > 2. the description in JDK-833 is insufficient: missing steps to > reproduce, expect

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-06-17 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-09 Thread Thiago Milczarek Sayao
On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v14]

2024-06-09 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-09 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 96 commits: - Merge branch 'refs/heads/master' into new_ime

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-06-07 Thread Thiago Milczarek Sayao
On Fri, 17 May 2024 19:10:17 GMT, Glavo wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 94 commits: >> >> - Merge branch 'master' into new_ime >> - A

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-06-07 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v13]

2024-05-27 Thread Thiago Milczarek Sayao
On Mon, 27 May 2024 09:30:18 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v13]

2024-05-27 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v21]

2024-05-27 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 95 commits: - Merge branch 'refs/heads/master' into new_im

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-05-27 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-26 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 22:02:33 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8322964: Optimize performance of CSS selector matching [v9]

2024-05-24 Thread Thiago Milczarek Sayao
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote: >> Improves performance of selector matching in the CSS subsystem. This is done >> by using custom set implementation which are highly optimized for the most >> common cases where the number of selectors is small (most commonly 1 or 2). >>

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:48:08 GMT, Jose Pereda wrote: >> The linux build seems to be failing because the lack of gcc-13 package. > > @tsayao the Ubuntu runner uses now 24.0.4. Your branch just needs to be > synced with head. @jperedadnr Thanks. @karthikpandelu I tested the sample with the Debia

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-05-23 Thread Thiago Milczarek Sayao
ply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in b

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:29:33 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:29:33 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
ply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Should still report location - Changes:

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-22 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 22:02:33 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-22 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-22 Thread Thiago Milczarek Sayao
On Sun, 12 May 2024 11:03:36 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage

2024-05-22 Thread Thiago Milczarek Sayao
This fixes two bugs appointed on the JBS issue: 1) Sometimes window was moving to the top left corner - seems to be a bug somewhere in `gdk_window_get_origin` when used before map (a X concept when the window appears). The change is to ignore the configure events (happens when location or size

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-20 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-17 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Integrated: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-15 Thread Thiago Milczarek Sayao
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. This pull request has

Withdrawn: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 12 May 2024 11:03:36 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Withdrawn: 8329820: [Linux] Prefer EGL over GLX

2024-05-13 Thread Thiago Milczarek Sayao
On Sat, 24 Feb 2024 17:54:47 GMT, Thiago Milczarek Sayao wrote: > Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: &

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-12 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v10]

2024-05-01 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v9]

2024-05-01 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v8]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 20:03:18 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v8]

2024-04-30 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with four additiona

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 12:22:34 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 12:22:34 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 12:22:34 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v6]

2024-04-29 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v5]

2024-04-29 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

2024-04-28 Thread Thiago Milczarek Sayao
On Thu, 25 Apr 2024 12:19:19 GMT, Lukasz Kostyra wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Forgot debug message > > modules/javafx.graphics/src/main/native-prism-

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v4]

2024-04-28 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

2024-04-23 Thread Thiago Milczarek Sayao
On Fri, 19 Apr 2024 14:42:23 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

2024-04-19 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-07 Thread Thiago Milczarek Sayao
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. High chance i

RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-06 Thread Thiago Milczarek Sayao
Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. It seems i3 replies with decorated sizes, even if window is not decorated. Won't hurt other WMs. - Commit messages: - - Fix for i3 menus size Changes: https://git.openjdk.org/jfx/pull/1437/files Webrev: ht

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v2]

2024-04-06 Thread Thiago Milczarek Sayao
org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: - Remove fprintf call - Changes: - all: https://git.openjdk.org/jfx/pull/1381/files - new: https://git.openjdk.org/jfx/pull/138

RFR: 8329820: [Linux] Prefer EGL over GLX

2024-04-06 Thread Thiago Milczarek Sayao
GLX is X only while EGL is need for Wayland and also works with X.org. I know there are limitations on Xorg and I still need to investigate it. GLX replacement for Xorg is not mandatory - this can be further discussed. This is a work in progress and it's on the first step (making it work). See

Re: RFR: 8329820: [Linux] Prefer EGL over GLX

2024-04-06 Thread Thiago Milczarek Sayao
On Tue, 2 Apr 2024 11:50:39 GMT, Lukasz Kostyra wrote: >> GLX is X only while EGL is need for Wayland and also works with X.org. >> >> I know there are limitations on Xorg and I still need to investigate it. >> >> GLX replacement for Xorg is not mandatory - this can be further discussed. >> >

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-03-24 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]

2024-02-26 Thread Thiago Milczarek Sayao
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-24 Thread Thiago Milczarek Sayao
On Tue, 20 Feb 2024 12:13:31 GMT, Jose Pereda wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add compile-time checks to GdkSeat > > I've just reverted the previous changes, and just applied the touch mask to > the

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-02-22 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-02-18 Thread Thiago Milczarek Sayao
9:04.webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 94 commits: - Merge branch 'master' into new_ime - Add si

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v19]

2024-02-18 Thread Thiago Milczarek Sayao
On Wed, 17 Jan 2024 17:10:24 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >>

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v17]

2024-01-17 Thread Thiago Milczarek Sayao
On Tue, 2 Jan 2024 16:58:10 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add check for jview > > modules/javafx.graphics/src/main/native-glass/gtk/gl

  1   2   3   4   5   >