Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-03 Thread Kevin Rushforth
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx17u/pull/102

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-03 Thread Ao Qi
On Fri, 3 Feb 2023 08:44:53 GMT, Johan Vos wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > I'm ok with this. > Apart from the functionality, this BP also makes it easier to backport future > changes in build.gradle (because it backports a structural chan

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-03 Thread Johan Vos
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. Marked as reviewed by jvos (Reviewer). I'm ok with this. Apart from the functionality, this BP also makes it easier to backport future changes in build.gradle (because it

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Johan Vos
On Tue, 31 Jan 2023 13:19:56 GMT, Ao Qi wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > RFC and RFR. Thanks. Should I take this PR out of Draft? @theaoqi Yes, if you take it out of draft, I'll review it. - PR: https://git.openjdk.org/jfx17u

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Ao Qi
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. RFC and RFR. Thanks. Should I take this PR out of Draft? - PR: https://git.openjdk.org/jfx17u/pull/102

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Ao Qi
On Mon, 9 Jan 2023 13:41:49 GMT, Kevin Rushforth wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > Backports to `jfx17u` require prior approval. You will need to seek such > approval from one of the project leads before taking this PR out of Draft. > > If

Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Kevin Rushforth
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. Backports to `jfx17u` require prior approval. You will need to seek such approval from one of the project leads before taking this PR out of Draft. If it is approved, the

[jfx17u] RFR: 8293214: Add support for Linux/LoongArch64

2023-02-02 Thread Ao Qi
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. - Commit messages: - 8293214: Add support for Linux/LoongArch64 Changes: https://git.openjdk.org/jfx17u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=102&range=00 Issue: https://bugs.