Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-16 Thread John Hendrikx
I think the issue in JDK-8206449 might not be entirely resolved. Even though `value` is now cleared in `ObjectBinding`, I noticed that `ExpressionHelper` also maintains the current value when there are change listeners registered. Unfortunately, it forgets to clear this when all change listene

Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-15 Thread Kevin Rushforth
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote: >> I introduced a bug with the fluent bindings PR which affects all >> ObjectBindings. >> >> This is the code that fails: >> >> SimpleObjectProperty condition = new >> SimpleObjectProperty<>(true); >> ObservableValue bindi

Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-15 Thread Nir Lisker
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote: >> I introduced a bug with the fluent bindings PR which affects all >> ObjectBindings. >> >> This is the code that fails: >> >> SimpleObjectProperty condition = new >> SimpleObjectProperty<>(true); >> ObservableValue bindi

Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-15 Thread John Hendrikx
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote: >> I introduced a bug with the fluent bindings PR which affects all >> ObjectBindings. >> >> This is the code that fails: >> >> SimpleObjectProperty condition = new >> SimpleObjectProperty<>(true); >> ObservableValue bindi

Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-15 Thread Michael Strauß
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote: >> I introduced a bug with the fluent bindings PR which affects all >> ObjectBindings. >> >> This is the code that fails: >> >> SimpleObjectProperty condition = new >> SimpleObjectProperty<>(true); >> ObservableValue bindi

Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-15 Thread John Hendrikx
On Fri, 15 Jul 2022 01:08:46 GMT, Michael Strauß wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change explanatory comment to block comment > > modules/javafx.base/src/main/java/javafx/beans/binding/ObjectBinding

Re: [jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

2022-07-15 Thread John Hendrikx
> I introduced a bug with the fluent bindings PR which affects all > ObjectBindings. > > This is the code that fails: > > SimpleObjectProperty condition = new > SimpleObjectProperty<>(true); > ObservableValue binding = condition.map(Object::toString); > > binding.addLis