Re: [jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

2022-08-19 Thread Nir Lisker
On Sat, 20 Aug 2022 00:27:32 GMT, Kevin Rushforth wrote: >> Added docs for inherited methods in `Bindings` subclasses. > > modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java line 174: > >> 172: /** >> 173: * Returns an immutable list of the

Re: [jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

2022-08-19 Thread Kevin Rushforth
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote: > Added docs for inherited methods in `Bindings` subclasses. Looks fine. I left a question about the missing `@return` tags, but it might not matter here depending on whether the IDEs care.

Re: [jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

2022-08-19 Thread Nir Lisker
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote: > Added docs for inherited methods in `Bindings` subclasses. I don't mind either way. I initially bundled it with the issue for fixing API docs, but decoupled it later and just thought it would be fine to do them both. The changes are very

Re: [jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

2022-08-19 Thread Kevin Rushforth
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote: > Added docs for inherited methods in `Bindings` subclasses. As far as I can tell, none of these are public API and so don't show up in the docs. (If they were, then the lack of an `@return` in a few places would generate a warning which we

Re: [jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

2022-08-18 Thread Nir Lisker
On Thu, 18 Aug 2022 19:21:39 GMT, Nir Lisker wrote: > Simple fixes for the inherited method docs. Closed in favor of #881. - PR: https://git.openjdk.org/jfx/pull/878

Re: [jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs [v2]

2022-08-18 Thread Nir Lisker
> Simple fixes for the inherited method docs. Nir Lisker has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains 19 new commits since the last

[jfx19] RFR: 8291906: Bindings.createXxxBinding inherit incorrect method docs

2022-08-18 Thread Nir Lisker
Simple fixes for the inherited method docs. - Commit messages: - Initial commit - 8290473: update Eclipse .classpath in apps, buildSrc - 8181084: JavaFX show big icons in system menu on macOS with Retina display - 8291908: VirtualFlow creates unneeded empty cells - 8291630: