Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes [v2]

2023-01-31 Thread Michael Strauß
On Tue, 31 Jan 2023 17:08:40 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8325: >> >>> 8323: } else if (count == 0) { >>> 8324: set(false); >>> 8325: } >> >> Is it worth adding a check for `count < 0` and

Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes [v2]

2023-01-31 Thread Michael Strauß
On Tue, 31 Jan 2023 16:42:32 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> refactoring > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8325: > >> 8323: }

Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes [v2]

2023-01-31 Thread Kevin Rushforth
On Fri, 13 Jan 2023 04:04:54 GMT, Michael Strauß wrote: >> When a scene graph contains multiple nested focused nodes (this can happen >> with `TableView` and other controls), the `focusWithin` bits that are >> cleared when a focused node is de-focused must only be cleared when there is >> no o

Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes [v2]

2023-01-17 Thread Ajit Ghaisas
On Fri, 13 Jan 2023 04:04:54 GMT, Michael Strauß wrote: >> When a scene graph contains multiple nested focused nodes (this can happen >> with `TableView` and other controls), the `focusWithin` bits that are >> cleared when a focused node is de-focused must only be cleared when there is >> no o

Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes [v2]

2023-01-12 Thread Michael Strauß
> When a scene graph contains multiple nested focused nodes (this can happen > with `TableView` and other controls), the `focusWithin` bits that are cleared > when a focused node is de-focused must only be cleared when there is no other > nested node in the scene graph that would also cause `foc