Re: Content Graph

2023-04-20 Thread Kevin Rushforth
I haven't waded into this discussion yet, but now that it's settling down a bit, I will offer a couple very brief thoughts. I am unconvinced that a content graph should be part of the JavaFX core. I can see how it might be useful to some apps, but it would be a large change w

Re: Content Graph

2023-04-20 Thread Andy Goryachev
x-dev on behalf of Michael Strauß Date: Thursday, April 13, 2023 at 11:56 To: openjfx-dev Subject: Content Graph I've previously proposed an enhancement to introduce a "document graph" to JavaFX that would solve a problem that many people have encountered over the years: http

Re: Content Graph

2023-04-20 Thread Michael Strauß
> Looking at the PR, there is one thing I have a 'bad feeling' with. > And that is that everything is done in an eager way. > E.g. we now maintain another list, the contentModel, even if you don't need > it. > I see why this API can be useful. And I even needed something like this, just > not ver

Aw: Content Graph

2023-04-20 Thread Marius Hanl
not very often. Performance wise this should not make a big impact, still something we may should discuss here.   -- Marius   Gesendet: Donnerstag, 13. April 2023 um 20:55 Uhr Von: "Michael Strauß" An: "openjfx-dev" Betreff: Content Graph I've previously proposed an en

Re: Content Graph

2023-04-19 Thread John Hendrikx
On 18/04/2023 19:14, Michael Strauß wrote: Here's a draft PR: https://github.com/openjdk/jfx/pull/1096 There are some API changes compared to my last email, the most notable being that the content graph can now contain arbitrary objects. This allows the content graph to directly cont

Re: Content Graph

2023-04-18 Thread Michael Strauß
Hi Robert, > This requires that a MenuButton always has a text, however a Skin could > exist that does not contain any text node (but only a bitmap, a simple > shape, etc.). AFAIK Skins separate controls from their concrete > representation. But that's the point of the

Re: Content Graph

2023-04-18 Thread Michael Strauß
Here's a draft PR: https://github.com/openjdk/jfx/pull/1096 There are some API changes compared to my last email, the most notable being that the content graph can now contain arbitrary objects. This allows the content graph to directly contain a ListView's item list, or a Labeled

Re: Content Graph

2023-04-17 Thread Robert Lichtenberger
e a method `printContentGraph(ContentNode root)`, which does the same as before, but works on the content graph. This is the output of that method: javafx.scene.layout.VBox javafx.scene.control.MenuButton javafx.content.Text This requires that a MenuButton always has a text, however a

Re: Content Graph

2023-04-14 Thread John Hendrikx
n't solve everything, but it would solve the SplitPane use case. 2) How far does a content graph go? It contains MenuItem. Should or will it contain ListView items? 3) Will this require a new observable list for every parent node, or is it going to be the same list for most of the nodes? O

Content Graph

2023-04-13 Thread Michael Strauß
raph is a black box in the presence of control skins, which makes it hard to reason about its structure. On top of that, several nodes that look like they are part of the scene graph (MenuItem or Tab) aren't scene graph nodes at all. 1) Content Graph We can solve this problem by adding