Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-21 Thread Markus Mack
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc,

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Andy Goryachev
On Thu, 20 Jun 2024 19:11:48 GMT, Markus Mack wrote: > adding empty series ah, right! > the tick marks on the axis are in incorrect this might be [JDK-8314754](https://bugs.openjdk.org/browse/JDK-8314754) - PR Comment:

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Markus Mack
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc,

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Andy Goryachev
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc,

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Andy Goryachev
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc,

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Markus Mack
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc,

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Markus Mack
On Thu, 20 Jun 2024 17:59:13 GMT, Andy Goryachev wrote: >> You'll need to add an additional point after adding the one with duplicate >> categories to see the exception in the console. Using the "Add Point" button >> in the monkey tester after using the context menu entry should reproduce the

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Andy Goryachev
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc,

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Andy Goryachev
On Thu, 20 Jun 2024 17:50:20 GMT, Markus Mack wrote: >> I've added a popup menu on the BarChart page in the Monkey Tester to test >> the case ... >> https://github.com/andy-goryachev-oracle/MonkeyTest > > You'll need to add an additional point after adding the one with duplicate > categories

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Markus Mack
On Thu, 20 Jun 2024 16:52:49 GMT, Andy Goryachev wrote: >> However, I don't see the issue if I just add a duplicate data point after >> the chart is rendered (the code jumps to line 218 (edit: 216, sorry) in the >> master branch). >> >> This makes me think that perhaps the fix should include

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

2024-06-20 Thread Markus Mack
> This PR provides the test case given in the JBS issue, and a simple fix for > the index calculation when inserting data after previous data with duplicate > categories. > > Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior > that was apparently assumed (but broken)