On Tue, 7 Mar 2023 13:33:42 GMT, Kevin Rushforth wrote:
>> Updated code to use `Math.ceil()`
>
> The `Math.ceil` is in the wrong place. It's the result of the division that
> will generate the fractional result that needs it:
>
>
> double screenHeight =
> Screen.getPrimary().getVisual
On Tue, 7 Mar 2023 07:18:07 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java
>> line 144:
>>
>>> 142: double rowHeight =
>>> ContextMenuContentShim.getContextMenuRowHeight(popup);
>>> 143: double screenHe
On Tue, 7 Mar 2023 00:23:48 GMT, Kevin Rushforth wrote:
> Have you run the test this on all platforms?
I have run the test in Mac and Windows multiple times. No failures found.
> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java
> line 62:
>
>> 60
On Fri, 3 Mar 2023 07:28:48 GMT, Karthik P K wrote:
>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
>> offset was carried forward when the list is replaced with small number of
>> items. Hence the scroll up arrow was displayed with empty popup.
>>
>> Changed code
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled
> offset was carried forward when the list is replaced with small number of
> items. Hence the scroll up arrow was displayed with empty popup.
>
> Changed code to scroll to top before popup display when content height