Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v11]

2023-05-08 Thread Jose Pereda
On Fri, 21 Apr 2023 00:36:55 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v11]

2023-04-21 Thread Andy Goryachev
On Fri, 21 Apr 2023 00:36:55 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v11]

2023-04-21 Thread Martin Fox
On Fri, 21 Apr 2023 15:47:36 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Enable compilation in Eclipse. > > Running with a Japanese keyboard and non-Latin option, all keys failed, > probably

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v11]

2023-04-21 Thread Andy Goryachev
On Fri, 21 Apr 2023 00:36:55 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v11]

2023-04-20 Thread Martin Fox
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys wh