Re: RFR: 8205067: Resizing window with TextField hides text value [v2]

2023-10-26 Thread Karthik P K
On Wed, 25 Oct 2023 15:28:14 GMT, Andy Goryachev wrote: > Can you provide an automated test for this fix? I agree on the points shared by @andy-goryachev-oracle on this. I also tried to write both unit test and system test but couldn't succeed because the issue could not be reproduced in the

Re: RFR: 8205067: Resizing window with TextField hides text value [v2]

2023-10-25 Thread Andy Goryachev
On Wed, 25 Oct 2023 15:19:13 GMT, Kevin Rushforth wrote: > Can you provide an automated test for this fix? I wonder. 1. this test ought to be headful, since the font metrics are involved 2. it might be better to develop a wider test that verifies that the caret (at least in the case of a

Re: RFR: 8205067: Resizing window with TextField hides text value [v2]

2023-10-25 Thread Kevin Rushforth
On Wed, 25 Oct 2023 10:12:01 GMT, Karthik P K wrote: >> Because of a missing conditional check in the `updateTextPos()`, the >> `textTranslateX` value was not getting updated when TextField size was >> changed as a result of resizing window. >> >> Updated the CENTER and LEFT cases in the

Re: RFR: 8205067: Resizing window with TextField hides text value [v2]

2023-10-25 Thread Karthik P K
> Because of a missing conditional check in the `updateTextPos()`, the > `textTranslateX` value was not getting updated when TextField size was > changed as a result of resizing window. > > Updated the CENTER and LEFT cases in the `updateTextPos()` method to fix the > issue. > > The fix can