On Thu, 17 Nov 2022 16:13:44 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8206430: review comments
>
> tests/system/src/test/java/test/util/Util.java line 313:
>
>> 311: * @param sta
On Wed, 16 Nov 2022 20:12:26 GMT, Andy Goryachev wrote:
>> 1. Introduced the following utility methods:
>> - Util.launch
>> - Util.shutdown
>> - Util.waitForLatch
>> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
>> tests' shutdowns.
>> 3. Replaced local waitForLatch
On Wed, 16 Nov 2022 20:12:26 GMT, Andy Goryachev wrote:
>> 1. Introduced the following utility methods:
>> - Util.launch
>> - Util.shutdown
>> - Util.waitForLatch
>> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
>> tests' shutdowns.
>> 3. Replaced local waitForLatch
On Wed, 16 Nov 2022 17:24:29 GMT, Andy Goryachev wrote:
> I am running the full test with this command - am I missing anything?
`/bin/sh gradlew -PSTUB_RUNTIME=../caches/modular-sdk -PFULL_TEST=true
-PUSE_ROBOT=true cleanTest test --no-daemon 2>&1 | tee ~/`date
+"test-%Y-%m%d-%H%M%S"`.log`
I u
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies with Util.waitForLatch
Andy Goryachev has updated the pu
On Wed, 16 Nov 2022 19:50:34 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8206430: util startup
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/DirectionalLightTest.java
> lin
On Wed, 16 Nov 2022 18:29:49 GMT, Andy Goryachev wrote:
>> 1. Introduced the following utility methods:
>> - Util.launch
>> - Util.shutdown
>> - Util.waitForLatch
>> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
>> tests' shutdowns.
>> 3. Replaced local waitForLatch
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies with Util.waitForLatch
Andy Goryachev has updated the pu
On Wed, 16 Nov 2022 17:54:17 GMT, Andy Goryachev wrote:
>> 1. Introduced the following utility methods:
>> - Util.launch
>> - Util.shutdown
>> - Util.waitForLatch
>> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
>> tests' shutdowns.
>> 3. Replaced local waitForLatch
On Wed, 16 Nov 2022 18:06:21 GMT, Andy Goryachev wrote:
>> 1. added a method with 15 second default. There are only 4 remaining that
>> use custom timeout, the first two use 5, the other two 50:
>> test.javafx.embed.swing.JFXPanelTest.doSetupOnce()
>> test.javafx.embed.swing.SwingFXUtilsTest.do
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies with Util.waitForLatch
Andy Goryachev has updated the pu
On Wed, 16 Nov 2022 17:49:22 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/util/Util.java line 317:
>>
>>> 315: * @param args - command line arguments
>>> 316: */
>>> 317: public static void launch (
>>
>> This looks like a useful utility. I think it would be help
On Wed, 16 Nov 2022 17:24:29 GMT, Andy Goryachev wrote:
> This is resulting in two test failures when run as a FULL system test run on
> my macBook with macOS 11.7.1.
>
> * test.javafx.scene.web.ColorChooserTest.testColorChooser()
> * test.robot.javafx.scene.ComboBoxTest.testComboBoxSceneChange
On Wed, 16 Nov 2022 00:20:19 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8206430: default timeout 15
>
> tests/system/src/test/java/test/util/Util.java line 317:
>
>> 315: * @param
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies with Util.waitForLatch
Andy Goryachev has updated the pu
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies with Util.waitForLatch
Andy Goryachev has updated the pu
On Wed, 16 Nov 2022 08:27:17 GMT, Ajit Ghaisas wrote:
> This is resulting in two test failures when run as a FULL system test run on
> my macBook with macOS 11.7.1.
>
> * test.javafx.scene.web.ColorChooserTest.testColorChooser()
> * test.robot.javafx.scene.ComboBoxTest.testComboBoxSceneChange1(
On Wed, 16 Nov 2022 00:21:53 GMT, Kevin Rushforth wrote:
>> 1. Introduced the following utility methods:
>> - Util.launch
>> - Util.shutdown
>> - Util.waitForLatch
>> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
>> tests' shutdowns.
>> 3. Replaced local waitForLatc
On Tue, 15 Nov 2022 18:00:59 GMT, Andy Goryachev wrote:
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies
On Tue, 15 Nov 2022 18:00:59 GMT, Andy Goryachev wrote:
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies
On Tue, 15 Nov 2022 18:00:59 GMT, Andy Goryachev wrote:
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch copies
1. Introduced the following utility methods:
- Util.launch
- Util.shutdown
- Util.waitForLatch
2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
tests' shutdowns.
3. Replaced local waitForLatch copies with Util.waitForLatch
-
Commit messages:
- 8206430: wai
22 matches
Mail list logo
