Re: RFR: 8271395: Fixing crash at printing [v2]

2022-08-03 Thread Kevin Rushforth
On Thu, 21 Jul 2022 11:54:01 GMT, Florian Kirmaier wrote: >> Inline > > I've worked in the feedback, thank you @kevinrushforth > Small note, this change is not used for a while and is therefore well tested. @FlorianKirmaier This PR is pending the following: 1. Merge upstream master into your

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-21 Thread Florian Kirmaier
On Thu, 21 Jul 2022 00:04:44 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8271395 >> QuantumRenderer is no longer public > > Inline I've worked in the feedback, thank you

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Kevin Rushforth
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Kevin Rushforth
On Wed, 20 Jul 2022 19:33:43 GMT, Phil Race wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8271395 >> QuantumRenderer is no longer public > >

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Phil Race
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Phil Race
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race