Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-07 Thread Kevin Rushforth
On Mon, 7 Aug 2023 09:30:47 GMT, Prasanta Sadhukhan wrote: > Since this PR solves issue 2 issues in windows and has not regressed anything > in mac (behaves same before and after fix), can we commit this and raise a > windows-toolkit JBS issue for mac to see why render scale is not updated for

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-07 Thread Prasanta Sadhukhan
On Thu, 3 Aug 2023 18:05:52 GMT, Andy Goryachev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Call updateSceneState with lock and in FX thread > > src="https://github.com/openjdk/jfx/assets/107069028/57b97

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-06 Thread Prasanta Sadhukhan
On Fri, 4 Aug 2023 05:46:35 GMT, Prasanta Sadhukhan wrote: > both windows (using EmbeddedFrameBug class listed earlier) shows O100% for > primary retina screen (should be 200%). @hjohn Seems like @andy-goryachev-oracle is telling it regressed after `updateSceneState` integration as previousl

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-03 Thread Prasanta Sadhukhan
On Thu, 3 Aug 2023 17:55:14 GMT, Andy Goryachev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Call updateSceneState with lock and in FX thread > > modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPa

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-03 Thread Prasanta Sadhukhan
On Thu, 3 Aug 2023 18:04:23 GMT, Andy Goryachev wrote: > The good: > > * image on both monitors (macOS) appear with no gaps > > * text on both monitors looks good, anti-aliasing works as expected > > > The bad: > > * both windows (using EmbeddedFrameBug class listed earlier) show

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-03 Thread Andy Goryachev
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan wrote: >> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > > Prasant

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-03 Thread Andy Goryachev
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan wrote: >> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > > Prasant

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-03 Thread Kevin Rushforth
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan wrote: >> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > > Prasant

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]

2023-08-02 Thread Prasanta Sadhukhan
> When the JavaFX scene is set before it is really shown, then the scale > factors are not properly propagated to the EmbeddedWindow, resulting in > showing wrong scales. > Fix is made to update scales to EmbeddedWindow Prasanta Sadhukhan has updated the pull request incrementally with one addi