Re: RFR: 8277848: Binding and Unbinding to List leads to memory leak [v8]

2024-06-06 Thread Florian Kirmaier
On Fri, 13 Jan 2023 12:35:12 GMT, John Hendrikx wrote: > Option 1 breaks the second example and leads to new problems; those new > problems are even harder to debug than a simple memory leak, as all the > elaborate tests all over the JavaFX code base that rely on System.gc() > clearly show. I

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-26 Thread Florian Kirmaier
On Sun, 22 Jan 2023 01:28:46 GMT, Michael Strauß wrote: >> Florian Kirmaier has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge remote-tracking branch 'origjfx/master' into >> JDK-8277848-list-binding-le

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-21 Thread Michael Strauß
On Thu, 12 Jan 2023 08:53:14 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which is

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-16 Thread Michael Strauß
On Thu, 12 Jan 2023 08:53:14 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which is

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-13 Thread John Hendrikx
On Fri, 13 Jan 2023 09:25:24 GMT, Florian Kirmaier wrote: >> Florian Kirmaier has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge remote-tracking branch 'origjfx/master' into >> JDK-8277848-list-binding

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-13 Thread Florian Kirmaier
On Thu, 12 Jan 2023 08:53:14 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which is

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

2023-01-12 Thread Florian Kirmaier
> Making the initial listener of the ListProperty weak fixes the problem. > The same is fixed for Set and Map. > Due to a smart implementation, this is done without any performance drawback. > (The trick is to have an object, which is both the WeakReference and the > Changelistener) > By implying