Re: RFR: 8278426: ImagePool uses terminally deprecated System.runFinalization method

2022-10-19 Thread Andy Goryachev
On Mon, 17 Oct 2022 14:02:52 GMT, Lukasz Kostyra wrote: > This change removes runFinalization calls in ImagePool::pruneCache method. > > Finalizers are deprecated in JDK 18 and will be removed soon. Marked as reviewed by angorya (Author). - PR: https://git.openjdk.org/jfx/pull/918

Re: RFR: 8278426: ImagePool uses terminally deprecated System.runFinalization method

2022-10-19 Thread Kevin Rushforth
On Mon, 17 Oct 2022 14:02:52 GMT, Lukasz Kostyra wrote: > This change removes runFinalization calls in ImagePool::pruneCache method. > > Finalizers are deprecated in JDK 18 and will be removed soon. Can you enable GitHub actions testing for your repo? See this comment: https://github.com/openj

RFR: 8278426: ImagePool uses terminally deprecated System.runFinalization method

2022-10-19 Thread Lukasz Kostyra
This change removes runFinalization calls in ImagePool::pruneCache method. Finalizers are deprecated in JDK 18 and will be removed soon. - Commit messages: - 8278426: Remove runFinalization calls in ImagePool::pruneCache Changes: https://git.openjdk.org/jfx/pull/918/files Webrev:

Re: RFR: 8278426: ImagePool uses terminally deprecated System.runFinalization method

2022-10-19 Thread Lukasz Kostyra
On Mon, 17 Oct 2022 14:02:52 GMT, Lukasz Kostyra wrote: > This change removes runFinalization calls in ImagePool::pruneCache method. > > Finalizers are deprecated in JDK 18 and will be removed soon. All done! Tests are in progress now. - PR: https://git.openjdk.org/jfx/pull/918

Re: RFR: 8278426: ImagePool uses terminally deprecated System.runFinalization method

2022-10-19 Thread Ambarish Rapte
On Mon, 17 Oct 2022 14:02:52 GMT, Lukasz Kostyra wrote: > This change removes runFinalization calls in ImagePool::pruneCache method. > > Finalizers are deprecated in JDK 18 and will be removed soon. LGTM. approving. We can integrate once OCA is verified. The title of the PR should be derived f