Re: RFR: 8289394: Fix warnings: Unlikely argument type [v2]

2022-07-18 Thread Nir Lisker
On Mon, 18 Jul 2022 21:50:00 GMT, Andy Goryachev wrote: >> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. >> >> This warning should be reclassified as an error, as it catches bugs missed >> by javac. In this case, the following places seem to contain bugs: >> - >>

Re: RFR: 8289394: Fix warnings: Unlikely argument type [v2]

2022-07-18 Thread Kevin Rushforth
On Mon, 18 Jul 2022 21:50:00 GMT, Andy Goryachev wrote: >> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. >> >> This warning should be reclassified as an error, as it catches bugs missed >> by javac. In this case, the following places seem to contain bugs: >> - >>

Re: RFR: 8289394: Fix warnings: Unlikely argument type [v2]

2022-07-18 Thread Andy Goryachev
> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. > > This warning should be reclassified as an error, as it catches bugs missed by > javac. In this case, the following places seem to contain bugs: > - > apps/samples/3DViewer/src/main/java/com/javafx/experiments/jfx3

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Kevin Rushforth
On Mon, 18 Jul 2022 19:26:59 GMT, Andy Goryachev wrote: > I suggest we keep the test and @SuppressWarnings("unlikely-arg-type") Agreed. What I was suggesting was that if there might be a problem (and I'm not sure whether there is), a separate bug could be filed to look into it. -

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Andy Goryachev
On Mon, 18 Jul 2022 14:33:16 GMT, Kevin Rushforth wrote: >> modules/javafx.base/src/test/java/test/javafx/collections/ObservableSubListTest.java >> line 161: >> >>> 159: @Test >>> 160: public void testEqualsOnAnotherType() { >>> 161: assertFalse(sublist.equals(Integer.valueOf(7)

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Kevin Rushforth
On Mon, 18 Jul 2022 17:01:35 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStyleMap_Test.java >> line 80: >> >>> 78: * @param map >>> 79: * @param decls >>> 80: */ >> >> This is unrelated to the fix, so it seems best to revert this.

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Andy Goryachev
On Mon, 18 Jul 2022 14:37:19 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStyleMap_Test.java >> line 83: >> >>> 81: private void checkFoundStyle(Property property, >>> Map, List

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Andy Goryachev
On Mon, 18 Jul 2022 14:34:42 GMT, Kevin Rushforth wrote: >> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. >> >> This warning should be reclassified as an error, as it catches bugs missed >> by javac. In this case, the following places seem to contain bugs: >> - >

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Kevin Rushforth
On Fri, 8 Jul 2022 20:31:31 GMT, Andy Goryachev wrote: > Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. > > This warning should be reclassified as an error, as it catches bugs missed by > javac. In this case, the following places seem to contain bugs: > - > apps/s

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-18 Thread Kevin Rushforth
On Sun, 17 Jul 2022 14:11:22 GMT, Nir Lisker wrote: >> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. >> >> This warning should be reclassified as an error, as it catches bugs missed >> by javac. In this case, the following places seem to contain bugs: >> - >> app

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-17 Thread Nir Lisker
On Fri, 8 Jul 2022 20:31:31 GMT, Andy Goryachev wrote: > Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. > > This warning should be reclassified as an error, as it catches bugs missed by > javac. In this case, the following places seem to contain bugs: > - > apps/s

Re: RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-08 Thread Kevin Rushforth
On Fri, 8 Jul 2022 20:31:31 GMT, Andy Goryachev wrote: > Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. > > This warning should be reclassified as an error, as it catches bugs missed by > javac. In this case, the following places seem to contain bugs: > - > apps/s

RFR: 8289394: Fix warnings: Unlikely argument type

2022-07-08 Thread Andy Goryachev
Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE. This warning should be reclassified as an error, as it catches bugs missed by javac. In this case, the following places seem to contain bugs: - apps/samples/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/Time