Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-10-25 Thread John Hendrikx
On Thu, 1 Sep 2022 17:38:39 GMT, Nir Lisker wrote: >> Edit: I missed some nuance, below is the correct version. >> >> There are three objects involved here: the parent observable, the new >> observable and the conditional. >> >> What `when` should achieve is to make the new observable and

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-04 Thread John Hendrikx
On Wed, 31 Aug 2022 17:07:17 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Thu, 1 Sep 2022 17:38:39 GMT, Nir Lisker wrote: >> Edit: I missed some nuance, below is the correct version. >> >> There are three objects involved here: the parent observable, the new >> observable and the conditional. >> >> What `when` should achieve is to make the new observable and

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread Nir Lisker
On Thu, 1 Sep 2022 13:10:49 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java >> line 266: >> >>> 264: * {@code condition} evaluates to {@code true}. This allows this >>> {@code ObservableValue} >>> 265: * and the conditional

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread Nir Lisker
On Thu, 1 Sep 2022 13:38:46 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java >> line 274: >> >>> 272: * >>> 273: * Returning {@code null} from the given condition is treated the >>> same as >>> 274: * returning {@code

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Wed, 31 Aug 2022 16:52:12 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
Please ignore the explanation below it is incorrect (I forgot that conditional and new observable reference each other). I've updated the comment on Github, not sure if these edits will show on the mailinglist. --John On 01/09/2022 15:14, John Hendrikx wrote: On Wed, 31 Aug 2022 17:04:31

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Wed, 31 Aug 2022 17:21:33 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Thu, 1 Sep 2022 13:42:26 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java >> line 302: >> >>> 300: * ObservableValue globalProperty = new >>> SimpleStringProperty("A"); >>> 301: * >>> 302: * // bind label's text to a

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Wed, 31 Aug 2022 17:19:37 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Wed, 31 Aug 2022 17:04:31 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Wed, 31 Aug 2022 16:54:32 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-09-01 Thread John Hendrikx
On Wed, 31 Aug 2022 17:33:41 GMT, Nir Lisker wrote: >> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java >> line 311: >> >>> 309: * @since 20 >>> 310: */ >>> 311: default ObservableValue when(ObservableValue >>> condition) { >> >> Discussion: name?

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-08-31 Thread Nir Lisker
On Fri, 15 Jul 2022 09:27:00 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-08-31 Thread Nir Lisker
On Fri, 15 Jul 2022 09:07:07 GMT, John Hendrikx wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > >

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-07-15 Thread John Hendrikx
On Fri, 15 Jul 2022 09:23:20 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

2022-07-15 Thread John Hendrikx
> This PR adds a new (lazy*) property on `Node` which provides a boolean which > indicates whether or not the `Node` is currently part of a `Scene`, which in > turn is part of a currently showing `Window`. > > It also adds a new fluent binding method on `ObservableValue` dubbed `when` > (open