Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-16 Thread Kevin Rushforth
On Thu, 15 Sep 2022 11:56:56 GMT, Jens Lidestrom wrote: >> Prior to this change it was not clear from the documentation if callers of >> Platform#runLater must perform >> any synchronisation to have writes of the calling thread be visible in the >> JavaFX Application >> Thread. It is important

Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-15 Thread Kevin Rushforth
On Thu, 15 Sep 2022 11:51:22 GMT, Jens Lidestrom wrote: >> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >> 157: >> >>> 155: * Memory consistency effects: Actions in a thread prior to >>> submitting a >>> 156: * runnable to this method happen-before

Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-15 Thread Kevin Rushforth
On Thu, 15 Sep 2022 11:59:44 GMT, Jens Lidestrom wrote: >> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >> 156: >> >>> 154: * >>> 155: * Memory consistency effects: Actions in a thread prior to >>> submitting a >>> 156: * runnable to this method

Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-15 Thread Jens Lidestrom
On Thu, 15 Sep 2022 11:50:17 GMT, Nir Lisker wrote: >> Jens Lidestrom has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use code formatting for 'runnable' > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >

Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-15 Thread Jens Lidestrom
On Thu, 15 Sep 2022 11:24:03 GMT, Kevin Rushforth wrote: >> Jens Lidestrom has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use code formatting for 'runnable' > > modules/javafx.graphics/src/main/java/javafx/application/Platform.java

Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-15 Thread Nir Lisker
On Thu, 15 Sep 2022 11:52:00 GMT, Jens Lidestrom wrote: >> Prior to this change it was not clear from the documentation if callers of >> Platform#runLater must perform >> any synchronisation to have writes of the calling thread be visible in the >> JavaFX Application >> Thread. It is important

Re: RFR: 8293839: Documentation memory consistency effects of runLater [v2]

2022-09-15 Thread Jens Lidestrom
> Prior to this change it was not clear from the documentation if callers of > Platform#runLater must perform > any synchronisation to have writes of the calling thread be visible in the > JavaFX Application > Thread. It is important to document either if callers can rely on runLater to > do