Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

2022-09-28 Thread Kevin Rushforth
On Tue, 27 Sep 2022 01:22:41 GMT, Alexander Matveev wrote: >> There was two problems: >> - uri.getPath() was returning null for jar URI, since it is not a standard >> URI and thus we did not detect file type based on extension. >> - Our signature detection for MP3 had a bug and did not

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

2022-09-27 Thread Andy Goryachev
On Tue, 27 Sep 2022 01:22:41 GMT, Alexander Matveev wrote: >> There was two problems: >> - uri.getPath() was returning null for jar URI, since it is not a standard >> URI and thus we did not detect file type based on extension. >> - Our signature detection for MP3 had a bug and did not

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

2022-09-26 Thread Alexander Matveev
On Mon, 26 Sep 2022 15:16:34 GMT, Andy Goryachev wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8293971: Loading new Media from resources can sometimes fail when loading >> from FXML [v2] > >

Re: RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

2022-09-26 Thread Alexander Matveev
> There was two problems: > - uri.getPath() was returning null for jar URI, since it is not a standard > URI and thus we did not detect file type based on extension. > - Our signature detection for MP3 had a bug and did not detect MP3 > correctly. See comments in code. > > Fixed by adding