On Sat, 10 Dec 2022 10:38:07 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Sat, 10 Dec 2022 10:38:07 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls the
>
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Wed, 30 Nov 2022 19:32:37 GMT, Kevin Rushforth wrote:
> Doing this makes it harder for reviewers to see what is actually being
> changed.
This is true, but it will the actual review process (especially, testing) move
faster. Or, we can wait for #919 to get integrated first.
-
On Wed, 30 Nov 2022 19:10:20 GMT, Andy Goryachev wrote:
> base on top of https://github.com/openjdk/jfx/pull/919
Doing this makes it harder for reviewers to see what is actually being changed.
Unless / until we enable the Skara support for dependent PRs (which the `jdk`
repo enables, but so
On Tue, 8 Nov 2022 10:11:40 GMT, Dean Wookey wrote:
>> Reviewers: @arapte @andy-goryachev-oracle
>
> @kevinrushforth, @arapte I clicked the request review on andy and it removed
> arapte for some reason. I guess that button shouldn't be clicked. Oops.
@DeanWookey :
Would it be possible to
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
On Tue, 8 Nov 2022 10:07:54 GMT, Dean Wookey wrote:
>> The code in ControlAcceleratorSupport adds its own scene listeners for each
>> node added. MenuButtonSkinBase does the same, unlike Control which only
>> calls it once.
>>
>> I think we could fix it in ControlAcceleratorSupport
On Tue, 8 Nov 2022 10:11:40 GMT, Dean Wookey wrote:
> I clicked the request review on andy and it removed arapte for some reason. I
> guess that button shouldn't be clicked. Oops.
That seems like a GitHub UI problem. I'll re-request a review from @arapte
-
PR:
On Fri, 4 Nov 2022 19:51:53 GMT, Kevin Rushforth wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>>
On Mon, 7 Nov 2022 18:11:28 GMT, Dean Wookey wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuButtonSkinBase.java
>> line 154:
>>
>>> 152: sceneChangeListener = (scene, oldValue, newValue) -> {
>>> 153: if (oldValue != null) {
>>> 154:
On Fri, 4 Nov 2022 21:14:20 GMT, Andy Goryachev wrote:
>> Dean Wookey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added changing scene tests for accelerator change listeners
>
>
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls the
>
On Fri, 4 Nov 2022 16:07:54 GMT, Dean Wookey wrote:
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls
On Fri, 4 Nov 2022 16:07:54 GMT, Dean Wookey wrote:
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls
On Fri, 4 Nov 2022 16:07:54 GMT, Dean Wookey wrote:
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls
On Fri, 4 Nov 2022 16:07:54 GMT, Dean Wookey wrote:
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls
When menu buttons are added and removed from the scene, an accelerator change
listener is added to each menu item in the menu. There is nothing stopping the
same change listener being added multiple times.
MenuButtonSkinBase calls the
21 matches
Mail list logo
