Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Alessadro Parisi
On Tue, 30 May 2023 15:37:29 GMT, Michael Strauß wrote: > > Talking about #511 and #1014. I think that both the APIs are quite nice > > additions to JavaFX. However I was thinking, @mstr2 can't the two features > > be split? It seems to me, correct me if I'm wrong, that the Platform > > Prefer

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Alessadro Parisi
On Thu, 11 May 2023 14:38:01 GMT, Michael Strauß wrote: >> Hi all, >> >> First of all, thanks for the efforts to integrate this new API into JavaFX. >> As a style theme developer myself I think this API is missing nowadays and >> will be a good addition to the SDK! >> >> A comment not related

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Thu, 11 May 2023 14:38:01 GMT, Michael Strauß wrote: >> Hi all, >> >> First of all, thanks for the efforts to integrate this new API into JavaFX. >> As a style theme developer myself I think this API is missing nowadays and >> will be a good addition to the SDK! >> >> A comment not related

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Pedro Duque Vieira
On Thu, 11 May 2023 14:38:01 GMT, Michael Strauß wrote: >> Hi all, >> >> First of all, thanks for the efforts to integrate this new API into JavaFX. >> As a style theme developer myself I think this API is missing nowadays and >> will be a good addition to the SDK! >> >> A comment not related

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Thu, 11 May 2023 11:38:14 GMT, Pedro Duque Vieira wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. > > Hi all, > > First of all, thanks for the efforts to integrate this new API into JavaFX. > As a style theme developer myself I thi

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Pedro Duque Vieira
On Thu, 2 Feb 2023 19:54:33 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Mon, 24 Apr 2023 19:24:31 GMT, Andy Goryachev wrote: > 1. ObservableMap. Is it unmodifiable? I'd expect it to be, since this API > exposes the properties of the underlying platform. Yes and no. It is unmodifiable as it relates to the `Map` contract: you can't add, remove, or change mappin

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Andy Goryachev
On Thu, 2 Feb 2023 19:54:33 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread airsquared
On Tue, 2 May 2023 12:31:20 GMT, Michael Strauß wrote: > But what do you do when a style theme uses platform preferences to adjust its > appearance (light/dark mode), but an application either doesn't want to offer > a dark mode, or wants the _application_ (not the OS) be able to toggle > ligh

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Mon, 24 Apr 2023 22:08:20 GMT, Andy Goryachev wrote: > I meant > > ``` > ObjectProperty Preferences.getProperty(String key); > Set listPropertyKeys(); > ``` > > it would also be nice to obtain a typed property right away. That might be > more difficult, since one needs to use a dedicated cl

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Wed, 3 May 2023 06:23:48 GMT, airsquared wrote: > Since this is mainly for if a user wants to adjust the preferences used in a > style theme, would it make sense to provide this feature for overriding > preferences in the style theme API? This could also give the user the option > to overri

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Andy Goryachev
On Mon, 24 Apr 2023 20:13:30 GMT, Michael Strauß wrote: > Do you mean that you want `Preferences.appearanceProperty()`, > `Preferences.backgroundColorProperty()` and > `Preferences.foregroundColorProperty()` to be returned as a list? For > example, by adding another method like: I meant Obj

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread John Hendrikx
On Mon, 24 Apr 2023 06:23:41 GMT, Michael Strauß wrote: > > I'm not convinced that a delayed change + commit system is the correct way > > to do this. Properties should behave the same everywhere in JavaFX and this > > seems to change how they work quite a bit. > > Instead, I propose to look at

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Mon, 24 Apr 2023 07:14:47 GMT, John Hendrikx wrote: > That's not quite what I meant. You can add listeners still and get instant > change notifications. Just like when I listen to the `backgroundProperty` of > a control, and someone changes it, I get notified instantly and the change is > r

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Sun, 9 Apr 2023 20:23:55 GMT, John Hendrikx wrote: > With the preferences Map, this could work similar perhaps; set a key to > whatever you want with put, and restore it to its original value by setting > it to null. That's how the current API works, with a little bit of added complexity:

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Mon, 24 Apr 2023 06:01:58 GMT, John Hendrikx wrote: > I'm not convinced that a delayed change + commit system is the correct way to > do this. Properties should behave the same everywhere in JavaFX and this > seems to change how they work quite a bit. > > Instead, I propose to look at how l

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread John Hendrikx
On Sun, 9 Apr 2023 17:33:42 GMT, Michael Strauß wrote: > In general, platform preferences correspond to OS-level settings and are > updated dynamically. Third-party themes might integrate platform preferences > into their look and feel, which is often what users expect to see. But > consider a

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread Michael Strauß
On Thu, 2 Feb 2023 19:54:33 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v3]

2023-07-24 Thread John Hendrikx
On Thu, 2 Feb 2023 19:54:33 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v3]

2023-02-02 Thread Michael Strauß
> **Note:** please also read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) to > learn about how the platform preferences API interacts with the proposed > `StyleTheme` and `Stage.appearance` features. > > Platform preferences are the preferred UI settings of