On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Tue, 30 Jan 2024 20:43:33 GMT, Martin Fox wrote:
>>> The order in which they get resolved doesn't matter.
>>
>> would it be possible to get
>> [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912) integrated first
>> then? It seems the scenario it addresses is narrower, and it will
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Tue, 30 Jan 2024 20:43:33 GMT, Martin Fox wrote:
> I submitted PR
thank you!
-
PR Comment: https://git.openjdk.org/jfx/pull/1351#issuecomment-1917861792
On Tue, 30 Jan 2024 17:33:06 GMT, Andy Goryachev wrote:
>>> > [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912). I put
>>> > together a fix for that bug but decided not to roll it into this PR.
>>>
>>> Are these two bugs independent? Should JDK-8320912 be resolved first?
>>
>> They
On Tue, 30 Jan 2024 17:21:37 GMT, Martin Fox wrote:
> The order in which they get resolved doesn't matter.
would it be possible to get
[JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912) integrated first
then? It seems the scenario it addresses is narrower, and it will be easier
to
On Tue, 30 Jan 2024 15:56:04 GMT, Andy Goryachev wrote:
> > [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912). I put together
> > a fix for that bug but decided not to roll it into this PR.
>
> Are these two bugs independent? Should JDK-8320912 be resolved first?
They are
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Mon, 29 Jan 2024 19:04:10 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> When IM enabled state changes we dismiss the IM window.
>
> ... and scenarios described in JDK-8088172 and JDK-8089803
On Tue, 30 Jan 2024 00:57:53 GMT, Martin Fox wrote:
> Currently it commits a zero-length string (which appears to be a no-op) and
> leaves the composition buffer untouched.
Correcting myself: it does clear the composition buffer. But the zero-length
commit doesn't seem to be doing what it
On Mon, 29 Jan 2024 19:04:10 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> When IM enabled state changes we dismiss the IM window.
>
> ... and scenarios described in JDK-8088172 and JDK-8089803
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
> In the Mac glass code the presence of "marked" text (which is tracked in the
> nsAttrBuffer) signals that an IME is active. In this state the current code
> assumes that when NSTextInputContext handles a `keyDown:` it will either
> generate a call to `insertText:replacementRange:` or one of
16 matches
Mail list logo
