Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v5]

2023-08-21 Thread Karthik P K
On Wed, 16 Aug 2023 20:32:54 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix character index calculation issue when Text node content is wrapped > > modules/javafx.graphics/src/main/java/com/

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v5]

2023-08-21 Thread Karthik P K
On Wed, 16 Aug 2023 20:15:05 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix character index calculation issue when Text node content is wrapped > > modules/javafx.graphics/src/main/java/com/

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v5]

2023-08-16 Thread Andy Goryachev
On Tue, 8 Aug 2023 13:57:31 GMT, Karthik P K wrote: >> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when Text node was embedded in >> TextFlow. Hence wrong character index value was calculated for the same. >> >> Since only

Re: RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v5]

2023-08-08 Thread Karthik P K
> The text run selected in `PrismTextLayout::getHitInfo()` method for character > index calculation was not correct when Text node was embedded in TextFlow. > Hence wrong character index value was calculated for the same. > > Since only x, y coordinates were available in the above mentioned meth